Skip to content

ops_replayer: fix signed/unsigned warning and add parameter range checking.#61164

Merged
chardan merged 1 commit intoceph:mainfrom
chardan:wip-objectstore-ops-replayer-sign-warning
Jan 10, 2025
Merged

ops_replayer: fix signed/unsigned warning and add parameter range checking.#61164
chardan merged 1 commit intoceph:mainfrom
chardan:wip-objectstore-ops-replayer-sign-warning

Conversation

@chardan
Copy link
Contributor

@chardan chardan commented Dec 20, 2024

ops_replayer

Fixes signedness warning and adds range checking to related worker thread parameters.

Reviewed-by: adamemerson

Signed-off-by: Jesse F. Williamson jfw@ibm.com

Contribution Guidelines

  • To sign and title your commits, please refer to Submitting Patches to Ceph.

  • If you are submitting a fix for a stable branch (e.g. "quincy"), please refer to Submitting Patches to Ceph - Backports for the proper workflow.

  • When filling out the below checklist, you may click boxes directly in the GitHub web UI. When entering or editing the entire PR message in the GitHub web UI editor, you may also select a checklist item by adding an x between the brackets: [x]. Spaces and capitalization matter when checking off items this way.

Checklist

  • Tracker (select at least one)
    • References tracker ticket
    • Very recent bug; references commit where it was introduced
    • New feature (ticket optional)
    • Doc update (no ticket needed)
    • Code cleanup (no ticket needed)
  • Component impact
    • Affects Dashboard, opened tracker ticket
    • Affects Orchestrator, opened tracker ticket
    • No impact that needs to be tracked
  • Documentation (select at least one)
    • Updates relevant documentation
    • No doc update is appropriate
  • Tests (select at least one)
Show available Jenkins commands
  • jenkins retest this please
  • jenkins test classic perf
  • jenkins test crimson perf
  • jenkins test signed
  • jenkins test make check
  • jenkins test make check arm64
  • jenkins test submodules
  • jenkins test dashboard
  • jenkins test dashboard cephadm
  • jenkins test api
  • jenkins test docs
  • jenkins render docs
  • jenkins test ceph-volume all
  • jenkins test ceph-volume tox
  • jenkins test windows
  • jenkins test rook e2e

@adamemerson
Copy link
Contributor

Push this to ceph-ci once you're done just to make sure it builds on shaman.

@adamemerson
Copy link
Contributor

jenkins test make check

@chardan
Copy link
Contributor Author

chardan commented Dec 20, 2024

@chardan
Copy link
Contributor Author

chardan commented Jan 2, 2025

jenkins make check

@chardan chardan marked this pull request as ready for review January 2, 2025 17:22
@chardan
Copy link
Contributor Author

chardan commented Jan 3, 2025

jenkins retest this please

@chardan
Copy link
Contributor Author

chardan commented Jan 3, 2025

jenkins test api

@cbodley
Copy link
Contributor

cbodley commented Jan 6, 2025

https://jenkins.ceph.com/job/ceph-api/87053/

ERROR: test_list_enabled_module (tasks.mgr.dashboard.test_mgr_module.MgrModuleTest)

@cbodley
Copy link
Contributor

cbodley commented Jan 6, 2025

jenkins test api

@chardan
Copy link
Contributor Author

chardan commented Jan 6, 2025

jenkins retest this please

@cbodley
Copy link
Contributor

cbodley commented Jan 6, 2025

https://jenkins.ceph.com/job/ceph-api/87140/

FAIL: test_all (tasks.mgr.dashboard.test_rgw.RgwBucketTest)

commented on https://tracker.ceph.com/issues/46735

@cbodley
Copy link
Contributor

cbodley commented Jan 6, 2025

jenkins test api

@chardan chardan force-pushed the wip-objectstore-ops-replayer-sign-warning branch from c6c7118 to ad7b481 Compare January 8, 2025 19:31
Signed-off-by: Jesse F. Williamson <1643380+chardan@users.noreply.github.com>
@chardan chardan force-pushed the wip-objectstore-ops-replayer-sign-warning branch from ad7b481 to 8de1828 Compare January 8, 2025 19:33
@chardan
Copy link
Contributor Author

chardan commented Jan 9, 2025

@chardan
Copy link
Contributor Author

chardan commented Jan 9, 2025

jenkins test api

@chardan chardan merged commit c4730a9 into ceph:main Jan 10, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants