Skip to content

qa: fix test_cephfs_mirror_stats failure#61076

Merged
vshankar merged 1 commit intoceph:mainfrom
joscollin:wip-B69232-test_cephfs_mirror_stats_fail
Mar 4, 2025
Merged

qa: fix test_cephfs_mirror_stats failure#61076
vshankar merged 1 commit intoceph:mainfrom
joscollin:wip-B69232-test_cephfs_mirror_stats_fail

Conversation

@joscollin
Copy link
Member

@joscollin joscollin commented Dec 13, 2024

Caused by #59875.

100MB files would take less than a second to sync, which makes no difference
in 'last_synced_end' and the test fails intermittently. We need to increase the
size of the files, as the time/duration is determined only in seconds.
Because of this, it also needs more sleep time before checking the status.

Fixes: https://tracker.ceph.com/issues/69232

Contribution Guidelines

  • To sign and title your commits, please refer to Submitting Patches to Ceph.

  • If you are submitting a fix for a stable branch (e.g. "quincy"), please refer to Submitting Patches to Ceph - Backports for the proper workflow.

  • When filling out the below checklist, you may click boxes directly in the GitHub web UI. When entering or editing the entire PR message in the GitHub web UI editor, you may also select a checklist item by adding an x between the brackets: [x]. Spaces and capitalization matter when checking off items this way.

Checklist

  • Tracker (select at least one)
    • References tracker ticket
    • Very recent bug; references commit where it was introduced
    • New feature (ticket optional)
    • Doc update (no ticket needed)
    • Code cleanup (no ticket needed)
  • Component impact
    • Affects Dashboard, opened tracker ticket
    • Affects Orchestrator, opened tracker ticket
    • No impact that needs to be tracked
  • Documentation (select at least one)
    • Updates relevant documentation
    • No doc update is appropriate
  • Tests (select at least one)
Show available Jenkins commands
  • jenkins retest this please
  • jenkins test classic perf
  • jenkins test crimson perf
  • jenkins test signed
  • jenkins test make check
  • jenkins test make check arm64
  • jenkins test submodules
  • jenkins test dashboard
  • jenkins test dashboard cephadm
  • jenkins test api
  • jenkins test docs
  • jenkins render docs
  • jenkins test ceph-volume all
  • jenkins test ceph-volume tox
  • jenkins test windows
  • jenkins test rook e2e

@github-actions github-actions bot added cephfs Ceph File System tests labels Dec 13, 2024
@joscollin joscollin force-pushed the wip-B69232-test_cephfs_mirror_stats_fail branch from 4d09335 to 5c125ce Compare December 13, 2024 05:25
@joscollin joscollin requested review from a team and vshankar December 13, 2024 08:16
@joscollin
Copy link
Member Author

@joscollin joscollin marked this pull request as draft December 16, 2024 04:17
@joscollin joscollin added the DNM label Dec 16, 2024
@joscollin
Copy link
Member Author

I see some valgrind failures on this one. Putting it DNM for now. Will push the update soon.

@vshankar vshankar marked this pull request as ready for review December 16, 2024 06:43
100MB files would take less than a second to sync, which makes no difference
in 'last_synced_end' and the test fails intermittently. We need to increase the
size of the files, as the time/duration is determined only in seconds.
Because of this, it also needs more sleep time before checking the status.

Fixes: https://tracker.ceph.com/issues/69232
Signed-off-by: Jos Collin <jcollin@redhat.com>
@joscollin joscollin force-pushed the wip-B69232-test_cephfs_mirror_stats_fail branch from 5c125ce to 005e492 Compare December 16, 2024 08:42
@joscollin joscollin removed the DNM label Dec 16, 2024
@vshankar
Copy link
Contributor

I see some valgrind failures on this one. Putting it DNM for now. Will push the update soon.

Did this change introduce something new which you fixed in the latest push?

@vshankar
Copy link
Contributor

I see some valgrind failures on this one. Putting it DNM for now. Will push the update soon.

Did this change introduce something new which you fixed in the latest push?

I doubt it did since this is a QA only fix, but just checking is some change was removed in-between commits.

@joscollin
Copy link
Member Author

I see some valgrind failures on this one. Putting it DNM for now. Will push the update soon.

Did this change introduce something new which you fixed in the latest push?

I've just added more sleep time in the new push, as I'm syncing bigger snapshots in this change. So obviously we need to wait more time to get the updated status.

@joscollin
Copy link
Member Author

jenkins test make check

@vshankar
Copy link
Contributor

This PR is under test in https://tracker.ceph.com/issues/69939.

Copy link
Contributor

@vshankar vshankar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@vshankar vshankar merged commit 31eae39 into ceph:main Mar 4, 2025
2 checks passed
@joscollin joscollin deleted the wip-B69232-test_cephfs_mirror_stats_fail branch March 5, 2025 03:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants