mds/SimpleLock: add has_xlock_by()#60996
Merged
Conversation
This replaces get_xlock_by() in cases where only a not-nullptr check is needed; this eliminates costly implicit reference counter manipulations. Signed-off-by: Max Kellermann <max.kellermann@ionos.com>
This eliminates more reference counter manipulations. Signed-off-by: Max Kellermann <max.kellermann@ionos.com>
batrick
approved these changes
Dec 18, 2024
Member
Author
|
@batrick, it's been nearly a month; who will do QA? |
Collaborator
|
Can one of the admins verify this patch? |
vshankar
approved these changes
Jan 15, 2025
Contributor
|
This PR is under test in https://tracker.ceph.com/issues/69546. |
Contributor
|
This is good to merge. Will prepare run wiki and merge... |
vshankar
approved these changes
Jan 27, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This replaces get_xlock_by() in cases where only a not-nullptr check is needed; this eliminates costly implicit reference counter manipulations.
Checklist