Skip to content

include/types.h, tools/cephfs: remove _BACKWARD_BACKWARD_WARNING_H#60993

Merged
idryomov merged 2 commits intoceph:mainfrom
MaxKellermann:types__backward_backward
Jan 27, 2025
Merged

include/types.h, tools/cephfs: remove _BACKWARD_BACKWARD_WARNING_H#60993
idryomov merged 2 commits intoceph:mainfrom
MaxKellermann:types__backward_backward

Conversation

@MaxKellermann
Copy link
Member

@MaxKellermann MaxKellermann commented Dec 9, 2024

This kludge has been obsolete for a long time and GCC 4.3 cannot compile Ceph anymore these days.

Checklist

  • Tracker (select at least one)
    • References tracker ticket
    • Very recent bug; references commit where it was introduced
    • New feature (ticket optional)
    • Doc update (no ticket needed)
    • Code cleanup (no ticket needed)
  • Component impact
    • Affects Dashboard, opened tracker ticket
    • Affects Orchestrator, opened tracker ticket
    • No impact that needs to be tracked
  • Documentation (select at least one)
    • Updates relevant documentation
    • No doc update is appropriate
  • Tests (select at least one)

@github-actions github-actions bot added the cephfs Ceph File System label Dec 9, 2024
@MaxKellermann
journal/Entry: include <sstream> instead of <strstream>
f082317 
The `strstream` header is obsolete.

Signed-off-by: Max Kellermann <max.kellermann@ionos.com>
@MaxKellermann
include/types.h, tools/cephfs: remove _BACKWARD_BACKWARD_WARNING_H
8bb28ef 
This kludge has been obsolete for a long time and GCC 4.3 cannot
compile Ceph anymore these days.

Signed-off-by: Max Kellermann <max.kellermann@ionos.com>
@MaxKellermann MaxKellermann force-pushed the types__backward_backward branch from ddb1caa to 8bb28ef Compare December 9, 2024 12:54
@MaxKellermann MaxKellermann requested a review from a team as a code owner December 9, 2024 12:54
@github-actions github-actions bot added the rbd label Dec 9, 2024
@MaxKellermann
Copy link
Member Author

MaxKellermann commented Jan 4, 2025

Posting a pointless comment to keep the bot from obsoleting this PR.

@MaxKellermann
Copy link
Member Author

MaxKellermann commented Jan 15, 2025

@vshankar test results?

@ceph-jenkins
Copy link
Collaborator

ceph-jenkins commented Jan 15, 2025

Can one of the admins verify this patch?

@vshankar
Copy link
Contributor

vshankar commented Jan 15, 2025

@vshankar test results?

In progress. Will be available tomorrow. Note that I batch multiple prs in a test branch.

idryomov
idryomov approved these changes Jan 15, 2025
View reviewed changes
Copy link
Contributor

@idryomov idryomov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ack from the RBD perspective

@vshankar
Copy link
Contributor

vshankar commented Jan 15, 2025

This PR is under test in https://tracker.ceph.com/issues/69546.

vshankar
vshankar approved these changes Jan 27, 2025
View reviewed changes
Copy link
Contributor

@vshankar vshankar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

https://tracker.ceph.com/projects/cephfs/wiki/Main#wip-vshankar-testing-20250115164543-debug

@idryomov idryomov merged commit 3874c48 into ceph:main Jan 27, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@vshankar vshankar vshankar approved these changes

@idryomov idryomov idryomov approved these changes

Assignees

No one assigned

Labels

cephfs Ceph File System rbd wip-vshankar-testing2

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@MaxKellermann @ceph-jenkins @vshankar @idryomov