Skip to content

qa/workunits/mon: ensure election strategy is "connectivity" for stretch mode#60927

Merged
kamoltat merged 1 commit intoceph:mainfrom
ljflores:wip-tracker-69107
Dec 9, 2024
Merged

qa/workunits/mon: ensure election strategy is "connectivity" for stretch mode#60927
kamoltat merged 1 commit intoceph:mainfrom
ljflores:wip-tracker-69107

Conversation

@ljflores
Copy link
Copy Markdown
Member

@ljflores ljflores commented Dec 3, 2024

The election strategy is randomly chosen for this type of test. Sometimes, the test passes if the "connectivity" election strategy happens to be picked. But if a different strategy, i.e. "classic", is picked, then the test will fail.

We can ensure that the election strategy is "connectivity" by setting it in the workunit with the ceph CLI command. Although connectivity was specified in stretch-mode-5-mons-8-osds.yaml, that config ultimately gets overridden by the "qa/mon_config" yaml.

Fixes: https://tracker.ceph.com/issues/69107

Contribution Guidelines

  • To sign and title your commits, please refer to Submitting Patches to Ceph.

  • If you are submitting a fix for a stable branch (e.g. "quincy"), please refer to Submitting Patches to Ceph - Backports for the proper workflow.

  • When filling out the below checklist, you may click boxes directly in the GitHub web UI. When entering or editing the entire PR message in the GitHub web UI editor, you may also select a checklist item by adding an x between the brackets: [x]. Spaces and capitalization matter when checking off items this way.

Checklist

  • Tracker (select at least one)
    • References tracker ticket
    • Very recent bug; references commit where it was introduced
    • New feature (ticket optional)
    • Doc update (no ticket needed)
    • Code cleanup (no ticket needed)
  • Component impact
    • Affects Dashboard, opened tracker ticket
    • Affects Orchestrator, opened tracker ticket
    • No impact that needs to be tracked
  • Documentation (select at least one)
    • Updates relevant documentation
    • No doc update is appropriate
  • Tests (select at least one)
Show available Jenkins commands
  • jenkins retest this please
  • jenkins test classic perf
  • jenkins test crimson perf
  • jenkins test signed
  • jenkins test make check
  • jenkins test make check arm64
  • jenkins test submodules
  • jenkins test dashboard
  • jenkins test dashboard cephadm
  • jenkins test api
  • jenkins test docs
  • jenkins render docs
  • jenkins test ceph-volume all
  • jenkins test ceph-volume tox
  • jenkins test windows
  • jenkins test rook e2e

@ljflores ljflores requested a review from a team as a code owner December 3, 2024 22:02
@ljflores
Copy link
Copy Markdown
Member Author

ljflores commented Dec 3, 2024

@ljflores ljflores requested a review from kamoltat December 3, 2024 22:12
…tch mode

The election strategy is randomly chosen for this type of test. Sometimes,
the test passes if the "connectivity" election strategy happens to be picked.
But if a different strategy, i.e. "classic", is picked, then the test will fail.

We can ensure that the election strategy is "connectivity" by setting it in the
workunit with the ceph CLI command. Although connectivity was specified in
stretch-mode-5-mons-8-osds.yaml, that config ultimately gets overridden by
the "qa/mon_config" yaml.

Fixes: https://tracker.ceph.com/issues/69107
Signed-off-by: Laura Flores <lflores@ibm.com>
Copy link
Copy Markdown
Member

@kamoltat kamoltat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you @ljflores for making this change, for some reason I didn't see this failure when I was reviewing runs ☹️

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants