squid: mds: trim mdlog when segments exceed threshold and trim was idle#60838
Merged
mchangir merged 3 commits intoceph:squidfrom Feb 6, 2025
Merged
squid: mds: trim mdlog when segments exceed threshold and trim was idle#60838mchangir merged 3 commits intoceph:squidfrom
mchangir merged 3 commits intoceph:squidfrom
Conversation
Signed-off-by: Venky Shankar <vshankar@redhat.com> (cherry picked from commit 7d11c70)
Credit goes to Patrick (@batrick) for identifying this. When there are huge number of subtree exports (such as done in export thrashing test), the MDS would log an EExport event. The EExport event is relatively large in size. This causes the MDS to log new minor log segments frequently. Moreover, the MDS logs a major segment (boundary) after a certain number of events have been logged. This casues large number of (minor) events to get build up and cause delays in trimming expired segments, since journal expire position is updated on segment boundaries. To mitigate this issue, the MDS now starts a major segment after a configured number of minor segments have been logged. This threshold is configurable by adjusting `mds_log_minor_segments_per_major_segment` MDS config (defaults to 16). Fixes: https://tracker.ceph.com/issues/66948 Signed-off-by: Venky Shankar <vshankar@redhat.com> (cherry picked from commit 718afe2) Conflicts: src/common/options/mds.yaml.in Minor conflict in mds.yaml.in for missing configs in squid release.
Signed-off-by: Venky Shankar <vshankar@redhat.com> (cherry picked from commit f54be33)
Contributor
Author
|
This PR is under test in https://tracker.ceph.com/issues/69422. |
Member
|
If you're not set to merge this yet, it'd be nice to include https://tracker.ceph.com/issues/69426#note-3 with this PR. |
Contributor
Author
I'll rebuild the branch with the additional fix. |
mchangir
approved these changes
Feb 6, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
backport tracker: https://tracker.ceph.com/issues/68919
backport of #60381
parent tracker: https://tracker.ceph.com/issues/66948
this backport was staged using ceph-backport.sh version 16.0.0.6848
find the latest version at https://github.com/ceph/ceph/blob/main/src/script/ceph-backport.sh