Skip to content

crimson/os/seastore/transaction_manager: improve get_extents_if_live()#60817

Merged
cyx1231st merged 4 commits intoceph:mainfrom
cyx1231st:wip-seastore-improve-get_extents_if_live
Nov 29, 2024
Merged

crimson/os/seastore/transaction_manager: improve get_extents_if_live()#60817
cyx1231st merged 4 commits intoceph:mainfrom
cyx1231st:wip-seastore-improve-get_extents_if_live

Conversation

@cyx1231st
Copy link
Member

@cyx1231st cyx1231st commented Nov 25, 2024

Probably fix https://tracker.ceph.com/issues/66852.

The existing logs weren't sufficient to prove this is certainly related.

Contribution Guidelines

  • To sign and title your commits, please refer to Submitting Patches to Ceph.

  • If you are submitting a fix for a stable branch (e.g. "quincy"), please refer to Submitting Patches to Ceph - Backports for the proper workflow.

  • When filling out the below checklist, you may click boxes directly in the GitHub web UI. When entering or editing the entire PR message in the GitHub web UI editor, you may also select a checklist item by adding an x between the brackets: [x]. Spaces and capitalization matter when checking off items this way.

Checklist

  • Tracker (select at least one)
    • References tracker ticket
    • Very recent bug; references commit where it was introduced
    • New feature (ticket optional)
    • Doc update (no ticket needed)
    • Code cleanup (no ticket needed)
  • Component impact
    • Affects Dashboard, opened tracker ticket
    • Affects Orchestrator, opened tracker ticket
    • No impact that needs to be tracked
  • Documentation (select at least one)
    • Updates relevant documentation
    • No doc update is appropriate
  • Tests (select at least one)
Show available Jenkins commands
  • jenkins retest this please
  • jenkins test classic perf
  • jenkins test crimson perf
  • jenkins test signed
  • jenkins test make check
  • jenkins test make check arm64
  • jenkins test submodules
  • jenkins test dashboard
  • jenkins test dashboard cephadm
  • jenkins test api
  • jenkins test docs
  • jenkins render docs
  • jenkins test ceph-volume all
  • jenkins test ceph-volume tox
  • jenkins test windows
  • jenkins test rook e2e

@cyx1231st cyx1231st requested a review from a team as a code owner November 25, 2024 07:54
@xxhdx1985126
Copy link
Contributor

jenkins test make check

@xxhdx1985126
Copy link
Contributor

jenkins test make check arm64

@cyx1231st
Copy link
Member Author

Signed-off-by: Yingxin Cheng <yingxin.cheng@intel.com>
…in get_extents_if_live

To make pin_list alive during parallel_for_each().

Signed-off-by: Yingxin Cheng <yingxin.cheng@intel.com>
It should not assume the paddr type from get_mappings is SEGMENT.

Signed-off-by: Yingxin Cheng <yingxin.cheng@intel.com>
…ve()

Signed-off-by: Yingxin Cheng <yingxin.cheng@intel.com>
@cyx1231st cyx1231st force-pushed the wip-seastore-improve-get_extents_if_live branch from 36833e8 to a783081 Compare November 28, 2024 06:19
@cyx1231st
Copy link
Member Author

Changeset: rebased, converted pin->get_logical_extent(t) with interruptor.

@cyx1231st
Copy link
Member Author

jenkins retest this please

@cyx1231st
Copy link
Member Author

jenkins test signed

@cyx1231st
Copy link
Member Author

jenkins test make check

4 similar comments
@cyx1231st
Copy link
Member Author

jenkins test make check

@cyx1231st
Copy link
Member Author

jenkins test make check

@cyx1231st
Copy link
Member Author

jenkins test make check

@cyx1231st
Copy link
Member Author

jenkins test make check

@cyx1231st
Copy link
Member Author

jenkins test api

1 similar comment
@cyx1231st
Copy link
Member Author

jenkins test api

@cyx1231st
Copy link
Member Author

I'll merge once the make check is passing (#60817 (comment), #60817 (comment))

@cyx1231st cyx1231st merged commit 739139b into ceph:main Nov 29, 2024
@cyx1231st cyx1231st deleted the wip-seastore-improve-get_extents_if_live branch November 29, 2024 03:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants