Skip to content

client: resolve bogus self-assignment#60761

Merged
batrick merged 1 commit intoceph:mainfrom
batrick:i68973
Feb 6, 2025
Merged

client: resolve bogus self-assignment#60761
batrick merged 1 commit intoceph:mainfrom
batrick:i68973

Conversation

@batrick
Copy link
Member

@batrick batrick commented Nov 18, 2024

Credit to Ilya Dryomov for spotting this.

[1] 1da6ef2#r1846415092

Fixes: 1da6ef2
Fixes: https://tracker.ceph.com/issues/68973

Contribution Guidelines

  • To sign and title your commits, please refer to Submitting Patches to Ceph.

  • If you are submitting a fix for a stable branch (e.g. "quincy"), please refer to Submitting Patches to Ceph - Backports for the proper workflow.

  • When filling out the below checklist, you may click boxes directly in the GitHub web UI. When entering or editing the entire PR message in the GitHub web UI editor, you may also select a checklist item by adding an x between the brackets: [x]. Spaces and capitalization matter when checking off items this way.

Checklist

  • Tracker (select at least one)
    • References tracker ticket
    • Very recent bug; references commit where it was introduced
    • New feature (ticket optional)
    • Doc update (no ticket needed)
    • Code cleanup (no ticket needed)
  • Component impact
    • Affects Dashboard, opened tracker ticket
    • Affects Orchestrator, opened tracker ticket
    • No impact that needs to be tracked
  • Documentation (select at least one)
    • Updates relevant documentation
    • No doc update is appropriate
  • Tests (select at least one)
Show available Jenkins commands
  • jenkins retest this please
  • jenkins test classic perf
  • jenkins test crimson perf
  • jenkins test signed
  • jenkins test make check
  • jenkins test make check arm64
  • jenkins test submodules
  • jenkins test dashboard
  • jenkins test dashboard cephadm
  • jenkins test api
  • jenkins test docs
  • jenkins render docs
  • jenkins test ceph-volume all
  • jenkins test ceph-volume tox
  • jenkins test windows
  • jenkins test rook e2e

@idryomov
Copy link
Contributor

[1] 1da6ef2#r1846415092

FWIW, this link doesn't take me to the comment thread, only #60283 (comment) does. I'm guessing it's the difference between a comment on a particular commit and a comment on the overall diff/PR.

Credit to  Ilya Dryomov for spotting this.

[1] ceph#60283 (comment)

Fixes: 1da6ef2
Fixes: https://tracker.ceph.com/issues/68973
Signed-off-by: Patrick Donnelly <pdonnell@ibm.com>
@batrick
Copy link
Member Author

batrick commented Nov 18, 2024

[1] 1da6ef2#r1846415092

FWIW, this link doesn't take me to the comment thread, only #60283 (comment) does. I'm guessing it's the difference between a comment on a particular commit and a comment on the overall diff/PR.

Fixed it, thanks.

@idryomov
Copy link
Contributor

jenkins test make check

@idryomov
Copy link
Contributor

jenkins test docs

@batrick
Copy link
Member Author

batrick commented Nov 21, 2024

jenkins test make check

@batrick
Copy link
Member Author

batrick commented Nov 21, 2024

jenkins test make check arm64

@batrick
Copy link
Member Author

batrick commented Nov 26, 2024

jenkins test make check

@batrick
Copy link
Member Author

batrick commented Nov 26, 2024

jenkins test make check arm64

1 similar comment
@batrick
Copy link
Member Author

batrick commented Dec 2, 2024

jenkins test make check arm64

@github-actions
Copy link

This pull request has been automatically marked as stale because it has not had any activity for 60 days. It will be closed if no further activity occurs for another 30 days.
If you are a maintainer or core committer, please follow-up on this pull request to identify what steps should be taken by the author to move this proposed change forward.
If you are the author of this pull request, thank you for your proposed contribution. If you believe this change is still appropriate, please ensure that any feedback has been addressed and ask for a code review.

@batrick
Copy link
Member Author

batrick commented Feb 5, 2025

This PR is under test in https://tracker.ceph.com/issues/69828.

@batrick
Copy link
Member Author

batrick commented Feb 6, 2025

@batrick batrick merged commit 04d74f5 into ceph:main Feb 6, 2025
@batrick batrick deleted the i68973 branch February 6, 2025 17:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants