squid: mds: Implement remove for ceph vxattrs #60752
Merged
mchangir merged 5 commits intoceph:squidfrom Jan 3, 2025
Merged
Conversation
For a variety of ceph xattrs, the setfattr remove isn't handled and "No such attribute" is returned. Add support to remove xattrs to match where docs say to clear value, one can remove or set to X value. When removing, add "default" value back to xattr depending on xattr name. Simplify current code to make clearer and minimize code reuse. Fixes: https://tracker.ceph.com/issues/62793 Signed-off-by: Christopher Hoffman <choffman@redhat.com> (cherry picked from commit 1f0a099)
Signed-off-by: Christopher Hoffman <choffman@redhat.com> (cherry picked from commit 26a352a)
Add tests to validate default and remove xattr behaviors. Signed-off-by: Christopher Hoffman <choffman@redhat.com> (cherry picked from commit 697c2fc)
…vxattrs Signed-off-by: Christopher Hoffman <choffman@redhat.com> (cherry picked from commit 7d3da6e)
Signed-off-by: Christopher Hoffman <choffman@redhat.com> (cherry picked from commit f5fe6a5)
Contributor
|
This PR is under test in https://tracker.ceph.com/issues/69030. |
Contributor
|
jenkins test api |
Contributor
|
jenkins test make check |
2 similar comments
Contributor
|
jenkins test make check |
Contributor
|
jenkins test make check |
mchangir
approved these changes
Jan 3, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
backport tracker: https://tracker.ceph.com/issues/68942
backport of #53755
parent tracker: https://tracker.ceph.com/issues/62793
this backport was staged using ceph-backport.sh version 16.0.0.6848
find the latest version at https://github.com/ceph/ceph/blob/main/src/script/ceph-backport.sh