Skip to content

os/bluestore: Unittest for deferred overwrite#60732

Merged
aclamk merged 2 commits intoceph:mainfrom
aclamk:wip-aclamk-deferred-overwrite-unittest
Mar 10, 2025
Merged

os/bluestore: Unittest for deferred overwrite#60732
aclamk merged 2 commits intoceph:mainfrom
aclamk:wip-aclamk-deferred-overwrite-unittest

Conversation

@aclamk
Copy link
Contributor

@aclamk aclamk commented Nov 14, 2024

Replicates deferred overwrite corruptions.

This is related to https://tracker.ceph.com/issues/68060 .

The procedure to reliably corrupt is somehow extensive and required:

  • introduction of trace points to BlueStore
  • ability to dynamically register new allocator

It should be decided whether we want to merge this work, or just use it for verifying correctness of a bugfix.

Contribution Guidelines

  • To sign and title your commits, please refer to Submitting Patches to Ceph.

  • If you are submitting a fix for a stable branch (e.g. "quincy"), please refer to Submitting Patches to Ceph - Backports for the proper workflow.

  • When filling out the below checklist, you may click boxes directly in the GitHub web UI. When entering or editing the entire PR message in the GitHub web UI editor, you may also select a checklist item by adding an x between the brackets: [x]. Spaces and capitalization matter when checking off items this way.

Checklist

  • Tracker (select at least one)
    • References tracker ticket
    • Very recent bug; references commit where it was introduced
    • New feature (ticket optional)
    • Doc update (no ticket needed)
    • Code cleanup (no ticket needed)
  • Component impact
    • Affects Dashboard, opened tracker ticket
    • Affects Orchestrator, opened tracker ticket
    • No impact that needs to be tracked
  • Documentation (select at least one)
    • Updates relevant documentation
    • No doc update is appropriate
  • Tests (select at least one)
Show available Jenkins commands
  • jenkins retest this please
  • jenkins test classic perf
  • jenkins test crimson perf
  • jenkins test signed
  • jenkins test make check
  • jenkins test make check arm64
  • jenkins test submodules
  • jenkins test dashboard
  • jenkins test dashboard cephadm
  • jenkins test api
  • jenkins test docs
  • jenkins render docs
  • jenkins test ceph-volume all
  • jenkins test ceph-volume tox
  • jenkins test windows
  • jenkins test rook e2e

@github-actions
Copy link

github-actions bot commented Dec 6, 2024

This pull request can no longer be automatically merged: a rebase is needed and changes have to be manually resolved

@aclamk aclamk force-pushed the wip-aclamk-deferred-overwrite-unittest branch from f76d5f1 to 2132835 Compare December 18, 2024 09:32
Added debug hooks for:
- init_alloc
- deferred start/stop/operation

This created framework for specific unit tests.
These functions are as name suggests debug level, only for unittests.

Signed-off-by: Adam Kupczyk <akupczyk@ibm.com>
Two possible cases of deferred write related corruption are replicated.
1. The case when L entries remain.
2. The case when deferred overwrites newly created BlueFS files

Provides unittest for:
https://tracker.ceph.com/issues/68060

Signed-off-by: Adam Kupczyk <akupczyk@ibm.com>
@aclamk aclamk force-pushed the wip-aclamk-deferred-overwrite-unittest branch from 2132835 to b2086ef Compare December 18, 2024 09:50
@github-actions
Copy link

This pull request has been automatically marked as stale because it has not had any activity for 60 days. It will be closed if no further activity occurs for another 30 days.
If you are a maintainer or core committer, please follow-up on this pull request to identify what steps should be taken by the author to move this proposed change forward.
If you are the author of this pull request, thank you for your proposed contribution. If you believe this change is still appropriate, please ensure that any feedback has been addressed and ask for a code review.

@github-actions github-actions bot added the stale label Feb 16, 2025
@aclamk aclamk merged commit b2086ef into ceph:main Mar 10, 2025
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant