Skip to content

cephfs-journal-tool: check the headers in dump file after journal recovery#60731

Merged
rishabh-d-dave merged 2 commits intoceph:mainfrom
joscollin:wip-B68954-check-headers-journal-recovery
Apr 23, 2025
Merged

cephfs-journal-tool: check the headers in dump file after journal recovery#60731
rishabh-d-dave merged 2 commits intoceph:mainfrom
joscollin:wip-B68954-check-headers-journal-recovery

Conversation

@joscollin
Copy link
Member

@joscollin joscollin commented Nov 14, 2024 •
edited
Loading

Fixes: https://tracker.ceph.com/issues/68954

Contribution Guidelines

  • To sign and title your commits, please refer to Submitting Patches to Ceph.

  • If you are submitting a fix for a stable branch (e.g. "quincy"), please refer to Submitting Patches to Ceph - Backports for the proper workflow.

  • When filling out the below checklist, you may click boxes directly in the GitHub web UI. When entering or editing the entire PR message in the GitHub web UI editor, you may also select a checklist item by adding an x between the brackets: [x]. Spaces and capitalization matter when checking off items this way.

Checklist

  • Tracker (select at least one)
    • References tracker ticket
    • Very recent bug; references commit where it was introduced
    • New feature (ticket optional)
    • Doc update (no ticket needed)
    • Code cleanup (no ticket needed)
  • Component impact
    • Affects Dashboard, opened tracker ticket
    • Affects Orchestrator, opened tracker ticket
    • No impact that needs to be tracked
  • Documentation (select at least one)
    • Updates relevant documentation
    • No doc update is appropriate
  • Tests (select at least one)
Show available Jenkins commands
  • jenkins retest this please
  • jenkins test classic perf
  • jenkins test crimson perf
  • jenkins test signed
  • jenkins test make check
  • jenkins test make check arm64
  • jenkins test submodules
  • jenkins test dashboard
  • jenkins test dashboard cephadm
  • jenkins test api
  • jenkins test docs
  • jenkins render docs
  • jenkins test ceph-volume all
  • jenkins test ceph-volume tox
  • jenkins test windows
  • jenkins test rook e2e

@github-actions github-actions bot added the cephfs Ceph File System label Nov 14, 2024
@joscollin
Copy link
Member Author

joscollin commented Nov 14, 2024

jenkins test docs

@joscollin
Copy link
Member Author

joscollin commented Nov 14, 2024

jenkins test api

@joscollin joscollin marked this pull request as draft November 14, 2024 09:24
@joscollin joscollin force-pushed the wip-B68954-check-headers-journal-recovery branch from c95e055 to 2571ab3 Compare November 14, 2024 09:30
@joscollin joscollin marked this pull request as ready for review November 14, 2024 09:31
@joscollin joscollin requested a review from vshankar November 14, 2024 13:42
@joscollin joscollin requested a review from a team November 28, 2024 12:09
@vshankar
Copy link
Contributor

vshankar commented Feb 10, 2025

@joscollin This seems fine, however, I think we can add a test, yes?

@joscollin
Copy link
Member Author

joscollin commented Feb 11, 2025

@joscollin This seems fine, however, I think we can add a test, yes?

Let me check.

@joscollin joscollin force-pushed the wip-B68954-check-headers-journal-recovery branch from 2571ab3 to 040a93c Compare February 11, 2025 13:23
@github-actions github-actions bot added the tests label Feb 11, 2025
@joscollin joscollin force-pushed the wip-B68954-check-headers-journal-recovery branch 3 times, most recently from 1f187ae to d1fcfe1 Compare February 13, 2025 08:44
@joscollin
Copy link
Member Author

joscollin commented Feb 13, 2025

Test passed:
https://pulpito.ceph.com/jcollin-2025-02-13_06:34:28-fs:functional-wip-jcollin-testing-1202-distro-default-smithi/

dparmar18
dparmar18 reviewed Feb 28, 2025
View reviewed changes
@joscollin
Copy link
Member Author

joscollin commented Mar 4, 2025

jenkins test api

@joscollin
Copy link
Member Author

joscollin commented Mar 4, 2025

jenkins test make check arm64

@github-actions
Copy link

github-actions bot commented Mar 4, 2025

This pull request can no longer be automatically merged: a rebase is needed and changes have to be manually resolved

@joscollin joscollin force-pushed the wip-B68954-check-headers-journal-recovery branch from d1fcfe1 to 5da18b4 Compare March 5, 2025 04:31
@joscollin
Copy link
Member Author

joscollin commented Mar 5, 2025

Rebased

@joscollin
Copy link
Member Author

joscollin commented Mar 17, 2025

jenkins test make check arm64

@joscollin
Copy link
Member Author

joscollin commented Apr 10, 2025

@rishabh-d-dave Please do qa for this.

@rishabh-d-dave rishabh-d-dave added the wip-rishabh-testing Rishabh's testing label label Apr 11, 2025
@rishabh-d-dave
Copy link
Contributor

rishabh-d-dave commented Apr 11, 2025

This PR is under test in https://tracker.ceph.com/issues/70897.

rishabh-d-dave
rishabh-d-dave approved these changes Apr 22, 2025
View reviewed changes
Copy link
Contributor

@rishabh-d-dave rishabh-d-dave left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

QA run was successful - https://tracker.ceph.com/projects/cephfs/wiki/QA_main_2025#wip-rishabh-testing-20250414181222-debug

@rishabh-d-dave
Copy link
Contributor

rishabh-d-dave commented Apr 22, 2025

jenkins test api

@rishabh-d-dave rishabh-d-dave added passed-qa for PRs that have passed QA but there's an on-going conversation, so merging would be premature and removed needs-qa labels Apr 22, 2025
@rishabh-d-dave
Copy link
Contributor

rishabh-d-dave commented Apr 22, 2025

jenkins test make check

@rishabh-d-dave
Copy link
Contributor

rishabh-d-dave commented Apr 22, 2025

jenkins test api

@rishabh-d-dave
Copy link
Contributor

rishabh-d-dave commented Apr 22, 2025

jenkins test make check

1 similar comment
@rishabh-d-dave
Copy link
Contributor

rishabh-d-dave commented Apr 22, 2025

jenkins test make check

@rishabh-d-dave
Copy link
Contributor

rishabh-d-dave commented Apr 22, 2025

jenkins test api

@rishabh-d-dave
Copy link
Contributor

rishabh-d-dave commented Apr 22, 2025

jenkins test make check arm64

@joscollin
Copy link
Member Author

joscollin commented Apr 23, 2025

jenkins test api

@joscollin
Copy link
Member Author

joscollin commented Apr 23, 2025

jenkins test make check arm64

1 similar comment
@joscollin
Copy link
Member Author

joscollin commented Apr 23, 2025

jenkins test make check arm64

@joscollin joscollin force-pushed the wip-B68954-check-headers-journal-recovery branch from 5da18b4 to d3a1f0d Compare April 23, 2025 05:59
@joscollin
Copy link
Member Author

joscollin commented Apr 23, 2025

@rishabh-d-dave rebased

@rishabh-d-dave
Copy link
Contributor

rishabh-d-dave commented Apr 23, 2025

@rishabh-d-dave rebased

Why did you rebase? There was no merge conflict and the PR was tested successfully before rebase.

@joscollin
Copy link
Member Author

joscollin commented Apr 23, 2025 •
edited
Loading

@rishabh-d-dave rebased

Why did you rebase? There was no merge conflict and the PR was tested successfully before rebase.

It doesn't pass the builds.

@joscollin
Copy link
Member Author

joscollin commented Apr 23, 2025

jenkins test make check

@rishabh-d-dave
Copy link
Contributor

rishabh-d-dave commented Apr 23, 2025

@rishabh-d-dave rebased

Why did you rebase? There was no merge conflict and the PR was tested successfully before rebase.

It doesn't pass the builds.

Okay. That didn't have anything to do with previous CI failures AFAICT.

@joscollin
Copy link
Member Author

joscollin commented Apr 23, 2025

@rishabh-d-dave rebased

Why did you rebase? There was no merge conflict and the PR was tested successfully before rebase.

It doesn't pass the builds.

Okay. That didn't have anything to do with previous CI failures AFAICT.

See, it's all green now @rishabh-d-dave

@rishabh-d-dave
Copy link
Contributor

rishabh-d-dave commented Apr 23, 2025

@rishabh-d-dave rebased

Why did you rebase? There was no merge conflict and the PR was tested successfully before rebase.

It doesn't pass the builds.

Okay. That didn't have anything to do with previous CI failures AFAICT.

See, it's all green now @rishabh-d-dave

Strange. All the issue before had nothing to do with code on this PR. Anyways, I'll keep this mind and use this trick some other time.

@rishabh-d-dave rishabh-d-dave merged commit bbed733 into ceph:main Apr 23, 2025
12 checks passed
@joscollin joscollin deleted the wip-B68954-check-headers-journal-recovery branch April 23, 2025 12:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@rishabh-d-dave rishabh-d-dave rishabh-d-dave approved these changes

@dparmar18 dparmar18 dparmar18 approved these changes

@vshankar vshankar Awaiting requested review from vshankar

Assignees

@dparmar18 dparmar18

Labels

bug-fix cephfs Ceph File System passed-qa for PRs that have passed QA but there's an on-going conversation, so merging would be premature tests wip-rishabh-testing Rishabh's testing label

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@joscollin @vshankar @rishabh-d-dave @dparmar18