Skip to content

squid: mds: getattr just waits the xlock to be released by the previous client#60691

Merged
mchangir merged 1 commit intoceph:squidfrom
vshankar:wip-67693-squid
Jan 2, 2025
Merged

squid: mds: getattr just waits the xlock to be released by the previous client#60691
mchangir merged 1 commit intoceph:squidfrom
vshankar:wip-67693-squid

Conversation

@vshankar
Copy link
Contributor

backport tracker: https://tracker.ceph.com/issues/67693


backport of #56602
parent tracker: https://tracker.ceph.com/issues/63906

this backport was staged using ceph-backport.sh version 16.0.0.6848
find the latest version at https://github.com/ceph/ceph/blob/main/src/script/ceph-backport.sh

…s client

When the previous client's setattr request is still holding the xlock
for the linklock/authlock/xattrlock/filelock locks, if the same client
send a getattr request it will use the projected inode to fill the
reply, while for other clients the getattr requests will use the
non-projected inode to fill replies. This causes inconsistent file
mode across multiple clients.

This will just skip batching the ops when any of the xlock is held.

Fixes: https://tracker.ceph.com/issues/63906
Signed-off-by: Xiubo Li <xiubli@redhat.com>
(cherry picked from commit b1ea37c)
@vshankar vshankar added this to the squid milestone Nov 11, 2024
@vshankar vshankar added the cephfs Ceph File System label Nov 11, 2024
@vshankar
Copy link
Contributor Author

This PR is under test in https://tracker.ceph.com/issues/69030.

Copy link
Contributor

@mchangir mchangir left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@mchangir mchangir merged commit 702cba8 into ceph:squid Jan 2, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants