Skip to content

mds: fix option mds_bal_overload_epochs#60686

Merged
vshankar merged 1 commit intoceph:mainfrom
zhsgao:mds_bal_overload_epochs
Feb 4, 2025
Merged

mds: fix option mds_bal_overload_epochs#60686
vshankar merged 1 commit intoceph:mainfrom
zhsgao:mds_bal_overload_epochs

Conversation

@zhsgao
Copy link
Contributor

@zhsgao zhsgao commented Nov 11, 2024 •
edited
Loading

When option mds_bal_overload_epochs was added by PR #53332,
two positions should have been modified, but one of them was overlooked.

Fixes: https://tracker.ceph.com/issues/68953
Signed-off-by: Zhansong Gao zhsgao@hotmail.com

Contribution Guidelines

  • To sign and title your commits, please refer to Submitting Patches to Ceph.

  • If you are submitting a fix for a stable branch (e.g. "quincy"), please refer to Submitting Patches to Ceph - Backports for the proper workflow.

  • When filling out the below checklist, you may click boxes directly in the GitHub web UI. When entering or editing the entire PR message in the GitHub web UI editor, you may also select a checklist item by adding an x between the brackets: [x]. Spaces and capitalization matter when checking off items this way.

Checklist

  • Tracker (select at least one)
    • References tracker ticket
    • Very recent bug; references commit where it was introduced
    • New feature (ticket optional)
    • Doc update (no ticket needed)
    • Code cleanup (no ticket needed)
  • Component impact
    • Affects Dashboard, opened tracker ticket
    • Affects Orchestrator, opened tracker ticket
    • No impact that needs to be tracked
  • Documentation (select at least one)
    • Updates relevant documentation
    • No doc update is appropriate
  • Tests (select at least one)
Show available Jenkins commands
  • jenkins retest this please
  • jenkins test classic perf
  • jenkins test crimson perf
  • jenkins test signed
  • jenkins test make check
  • jenkins test make check arm64
  • jenkins test submodules
  • jenkins test dashboard
  • jenkins test dashboard cephadm
  • jenkins test api
  • jenkins test docs
  • jenkins render docs
  • jenkins test ceph-volume all
  • jenkins test ceph-volume tox
  • jenkins test windows
  • jenkins test rook e2e

@github-actions github-actions bot added the cephfs Ceph File System label Nov 11, 2024
@zhsgao zhsgao force-pushed the mds_bal_overload_epochs branch from 8d42583 to cc639c2 Compare November 11, 2024 13:35
batrick
batrick previously requested changes Nov 13, 2024
View reviewed changes
Copy link
Member

@batrick batrick left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please create a tracker issue so that this issue can be tracked for backporting.

Then, please annotate the commit which fixes/resolves a Ceph tracker issue with:

Fixes: http://tracker.ceph.com/issues/...

This is essential when examining the history of the repository (this commit fixes what) and helps merge scripts identify issues that have been resolved by a merge. See this article on GitHub on how to amend commits and update your pull request.

@zhsgao zhsgao force-pushed the mds_bal_overload_epochs branch from cc639c2 to cf4d9b9 Compare November 14, 2024 02:47
@zhsgao
Copy link
Contributor Author

zhsgao commented Nov 14, 2024

Please create a tracker issue so that this issue can be tracked for backporting.

Then, please annotate the commit which fixes/resolves a Ceph tracker issue with:

Fixes: http://tracker.ceph.com/issues/...

This is essential when examining the history of the repository (this commit fixes what) and helps merge scripts identify issues that have been resolved by a merge. See this article on GitHub on how to amend commits and update your pull request.

OK, it's done.

@github-actions
Copy link

github-actions bot commented Jan 13, 2025

This pull request has been automatically marked as stale because it has not had any activity for 60 days. It will be closed if no further activity occurs for another 30 days.
If you are a maintainer or core committer, please follow-up on this pull request to identify what steps should be taken by the author to move this proposed change forward.
If you are the author of this pull request, thank you for your proposed contribution. If you believe this change is still appropriate, please ensure that any feedback has been addressed and ask for a code review.

@github-actions github-actions bot added the stale label Jan 13, 2025
@ceph-jenkins
Copy link
Collaborator

ceph-jenkins commented Jan 13, 2025

Can one of the admins verify this patch?

@github-actions github-actions bot removed the stale label Jan 13, 2025
@vshankar
Copy link
Contributor

vshankar commented Jan 15, 2025

This PR is under test in https://tracker.ceph.com/issues/69546.

vshankar
vshankar approved these changes Jan 27, 2025
View reviewed changes
Copy link
Contributor

@vshankar vshankar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

https://tracker.ceph.com/projects/cephfs/wiki/Main#wip-vshankar-testing-20250115164543-debug

@vshankar
Copy link
Contributor

vshankar commented Jan 27, 2025

jenkins test make check

1 similar comment
@vshankar
Copy link
Contributor

vshankar commented Jan 29, 2025

jenkins test make check

@zhsgao @vshankar
mds: fix option mds_bal_overload_epochs
2f4a6b8 
When option mds_bal_overload_epochs was added, two positions
should have been modified, but one of them was overlooked.

Fixes: https://tracker.ceph.com/issues/68953
Signed-off-by: Zhansong Gao <zhsgao@hotmail.com>
@vshankar vshankar force-pushed the mds_bal_overload_epochs branch from cf4d9b9 to 2f4a6b8 Compare January 30, 2025 04:12
@vshankar
Copy link
Contributor

vshankar commented Jan 30, 2025

(force pushed for jenkins tests)

@vshankar
Copy link
Contributor

vshankar commented Jan 30, 2025

jenkins test api

@vshankar vshankar dismissed batrick’s stale review February 4, 2025 07:51

Comment addressed.

@vshankar vshankar merged commit a6db252 into ceph:main Feb 4, 2025
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@vshankar vshankar vshankar approved these changes

@batrick batrick batrick left review comments

Assignees

No one assigned

Labels

cephfs Ceph File System

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@zhsgao @ceph-jenkins @vshankar @batrick