reef: mgr: allow disabling always-on modules#60563
Merged
Conversation
anthonyeleven
approved these changes
Oct 30, 2024
75c8140 to
8244267
Compare
Contributor
Author
|
@vshankar Please pick this PR for QA sooner since it's associated with a BZ. |
Contributor
Author
|
jenkins test make check |
Contributor
Right now we have lots of unrelated failures due to some mgr module. See: https://ceph-storage.slack.com/archives/C1HFZTW81/p1731585993248769 |
|
This pull request can no longer be automatically merged: a rebase is needed and changes have to be manually resolved |
Following log message has 3 distinct information (enabled modules, modules that are alwats on and total number of commands enabled) printed on the same line which makes it hard to find one of the information and also makes it comparatively hard to read - 2024-07-17T17:21:16.609+0530 7f534ae006c0 0 mon.a@0(leader).mgr e0 create_initial initial modules iostat,nfs,volumes, always on modules balancer,crash,devicehealth,orchestrator,pg_autoscaler,progress,status,telemetry, 50 commands With this commit it would be easier to read and find needed info - 2024-07-17T17:21:16.609+0530 7f534ae006c0 0 mon.a@0(leader).mgr e0 create_initial initial modules: iostat,nfs,volumes 2024-07-17T17:21:16.609+0530 7f534ae006c0 0 mon.a@0(leader).mgr e0 create_initial always on modules: balancer,crash,devicehealth,orchestrator,pg_autoscaler,progress,status,telemetry 2024-07-17T17:21:16.609+0530 7f534ae006c0 0 mon.a@0(leader).mgr e0 create_initial 50 commands Signed-off-by: Rishabh Dave <ridave@redhat.com> (cherry picked from commit e830f89)
It becomes easier to understand logs when whether command succeeded or not are also logged. Signed-off-by: Rishabh Dave <ridave@redhat.com> (cherry picked from commit 4374ac7)
Add a new command ("ceph mgr module force disable <module>") that allows
forcibly disabling an always-on module. This command should ideally only
be used to for cluster recovery.
Fixes: https://tracker.ceph.com/issues/66005
Signed-off-by: Rishabh Dave <ridave@redhat.com>
(cherry picked from commit 9962772)
Signed-off-by: Rishabh Dave <ridave@redhat.com> (cherry picked from commit 0abc227) Conflicts: qa/cephfs/overrides/ignorelist_health.yaml - this file had more entries on main branch compared to this (reef) branch. qa/tasks/cephfs/test_admin.py - this file add more tests and a set of tests next to test introduced in this patch-series that are not yet backported.
disabled now. Signed-off-by: Rishabh Dave <ridave@redhat.com> (cherry picked from commit 3232f6b)
8244267 to
2bea6c3
Compare
Contributor
Author
|
jenkins test make check |
1 similar comment
Contributor
|
jenkins test make check |
Contributor
|
This PR is under test in https://tracker.ceph.com/issues/69881. |
Contributor
|
This PR is under test in https://tracker.ceph.com/issues/70178. |
Contributor
Probably obsolete. |
Contributor
|
This PR is under test in https://tracker.ceph.com/issues/71521. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
NOTE: this backport PR has one less commit compared to parent PR because it was backported separately by backport team. See: #60496.
backport tracker: https://tracker.ceph.com/issues/68679
backport of #58647
parent tracker: https://tracker.ceph.com/issues/66005
this backport was staged using ceph-backport.sh version 16.0.0.6848
find the latest version at https://github.com/ceph/ceph/blob/main/src/script/ceph-backport.sh