Skip to content

qa/dashboard: fix tasks.mgr.dashboard.test_health.HealthTest#60511

Merged
nizamial09 merged 2 commits intoceph:mainfrom
rhcs-dashboard:health-test-fix
Nov 11, 2024
Merged

qa/dashboard: fix tasks.mgr.dashboard.test_health.HealthTest#60511
nizamial09 merged 2 commits intoceph:mainfrom
rhcs-dashboard:health-test-fix

Conversation

@nizamial09
Copy link
Member

@nizamial09 nizamial09 commented Oct 28, 2024 •
edited
Loading

as per: https://tracker.ceph.com/issues/47612#note-14

Fixes: https://tracker.ceph.com/issues/47612
Fixes: https://tracker.ceph.com/issues/62972

Contribution Guidelines

  • To sign and title your commits, please refer to Submitting Patches to Ceph.

  • If you are submitting a fix for a stable branch (e.g. "quincy"), please refer to Submitting Patches to Ceph - Backports for the proper workflow.

  • When filling out the below checklist, you may click boxes directly in the GitHub web UI. When entering or editing the entire PR message in the GitHub web UI editor, you may also select a checklist item by adding an x between the brackets: [x]. Spaces and capitalization matter when checking off items this way.

Checklist

  • Tracker (select at least one)
    • References tracker ticket
    • Very recent bug; references commit where it was introduced
    • New feature (ticket optional)
    • Doc update (no ticket needed)
    • Code cleanup (no ticket needed)
  • Component impact
    • Affects Dashboard, opened tracker ticket
    • Affects Orchestrator, opened tracker ticket
    • No impact that needs to be tracked
  • Documentation (select at least one)
    • Updates relevant documentation
    • No doc update is appropriate
  • Tests (select at least one)
Show available Jenkins commands
  • jenkins retest this please
  • jenkins test classic perf
  • jenkins test crimson perf
  • jenkins test signed
  • jenkins test make check
  • jenkins test make check arm64
  • jenkins test submodules
  • jenkins test dashboard
  • jenkins test dashboard cephadm
  • jenkins test api
  • jenkins test docs
  • jenkins render docs
  • jenkins test ceph-volume all
  • jenkins test ceph-volume tox
  • jenkins test windows
  • jenkins test rook e2e

@nizamial09 nizamial09 requested a review from epuertat October 28, 2024 05:46
@nizamial09 nizamial09 requested a review from a team as a code owner October 28, 2024 05:46
@nizamial09 nizamial09 requested review from prgoel-code and removed request for a team October 28, 2024 05:46
@nizamial09
Copy link
Member Author

nizamial09 commented Oct 28, 2024

@epuertat: created the fix as said in https://tracker.ceph.com/issues/47612#note-14

@nizamial09
Copy link
Member Author

nizamial09 commented Oct 29, 2024

jenkins test api

@nizamial09
Copy link
Member Author

nizamial09 commented Oct 30, 2024

1st api tests run passed

@nizamial09
Copy link
Member Author

nizamial09 commented Oct 30, 2024

jenkins test api

@nizamial09
Copy link
Member Author

nizamial09 commented Oct 30, 2024

@epuertat fyi, i added one more commit to the other api failure:

epuertat
epuertat approved these changes Oct 30, 2024
View reviewed changes
@nizamial09 nizamial09 force-pushed the health-test-fix branch 2 times, most recently from c46374f to f5efacd Compare November 4, 2024 08:18
@nizamial09
Copy link
Member Author

nizamial09 commented Nov 4, 2024

jenkins test api

@nizamial09
Copy link
Member Author

nizamial09 commented Nov 5, 2024

fixed make check and repushed

@nizamial09 nizamial09 force-pushed the health-test-fix branch 2 times, most recently from 1aeee5a to 3ebb16e Compare November 6, 2024 09:50
@nizamial09
Copy link
Member Author

nizamial09 commented Nov 6, 2024

i still see the same issue here again: https://jenkins.ceph.com/job/ceph-api/84504/consoleFull

added one more exception to see where the error is getting caught.. also increased the log verbosity

@github-actions github-actions bot added the pybind label Nov 6, 2024
@nizamial09
Copy link
Member Author

nizamial09 commented Nov 6, 2024

jenkins test api

@nizamial09
Copy link
Member Author

nizamial09 commented Nov 7, 2024

weird failure

[1483/1715] Building CXX object src/rgw/CMakeFiles/rgw_a.dir/rgw_auth_keystone.cc.o
[1484/1715] Building CXX object src/rgw/CMakeFiles/rgw_common.dir/driver/d4n/rgw_sal_d4n.cc.o
ninja: error: remove(../src/pybind/mgr/dashboard/frontend/node_modules): Directory not empty
ninja: error: remove(/home/jenkins-build/build/workspace/ceph-api/src/pybind/mgr/dashboard/frontend/node_modules): Directory not empty
ninja: build stopped: interrupted by user.
ninja: error: remove(../src/pybind/mgr/dashboard/frontend/node_modules): Directory not empty
ninja: error: remove(/home/jenkins-build/build/workspace/ceph-api/src/pybind/mgr/dashboard/frontend/node_modules): Directory not empty
Build step 'Execute shell' marked build as failure
[PostBuildScript] - [INFO] Executing post build scripts.

@nizamial09
Copy link
Member Author

nizamial09 commented Nov 7, 2024

jenkins test api

1 similar comment
@nizamial09
Copy link
Member Author

nizamial09 commented Nov 7, 2024

jenkins test api

@nizamial09 nizamial09 mentioned this pull request Nov 7, 2024
Closed
14 tasks
@nizamial09
Copy link
Member Author

nizamial09 commented Nov 8, 2024

jenkins test api

@nizamial09
qa/dashboard: fix test_list_enabled_module failure
a2a4a34 
Check the ports availability and go for a new port if the current one is
not available

Fixes: https://tracker.ceph.com/issues/62972
Signed-off-by: Nizamudeen A <nia@redhat.com>
@nizamial09
Copy link
Member Author

nizamial09 commented Nov 11, 2024

failed before starting: https://jenkins.ceph.com/job/ceph-api/84792/consoleFull

2024-11-10T14:39:00.695+0000 7feccb944480 -1 osd.2 0 log_to_monitors true
Using guessed paths /home/jenkins-build/build/workspace/ceph-api/build/lib/ ['/home/jenkins-build/build/workspace/ceph-api/qa', '/home/jenkins-build/build/workspace/ceph-api/build/lib/cython_modules/lib.3', '/home/jenkins-build/build/workspace/ceph-api/src/pybind']
Traceback (most recent call last):
  File "/home/jenkins-build/build/workspace/ceph-api/build/../qa/tasks/vstart_runner.py", line 1610, in <module>
    exec_test()
  File "/home/jenkins-build/build/workspace/ceph-api/build/../qa/tasks/vstart_runner.py", line 1448, in exec_test
    remote.run(args=args, env=vstart_env, timeout=(10 * 60))
  File "/home/jenkins-build/build/workspace/ceph-api/build/../qa/tasks/vstart_runner.py", line 462, in run
    return self._do_run(**kwargs)
  File "/home/jenkins-build/build/workspace/ceph-api/build/../qa/tasks/vstart_runner.py", line 501, in _do_run
    proc.wait(timeout)
  File "/home/jenkins-build/build/workspace/ceph-api/build/../qa/tasks/vstart_runner.py", line 265, in wait
    raise CommandFailedError(self.args, self.exitstatus)
teuthology.exceptions.CommandFailedError: Command failed with status 1: '../src/vstart.sh -n --nolockdep'

@nizamial09
Copy link
Member Author

nizamial09 commented Nov 11, 2024

jenkins test api

@nizamial09
Copy link
Member Author

nizamial09 commented Nov 11, 2024

Merging this now since most of the runs I did above didn't fail on the errors that were mentioned in the trackers. Will wait for more runs after the merge.

@nizamial09 nizamial09 merged commit 9d79a06 into ceph:main Nov 11, 2024
@nizamial09 nizamial09 deleted the health-test-fix branch November 11, 2024 10:09
This was referenced Mar 13, 2025
Merged
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@epuertat epuertat epuertat approved these changes

@prgoel-code prgoel-code Awaiting requested review from prgoel-code prgoel-code is a code owner automatically assigned from ceph/dashboard

Assignees

No one assigned

Labels

dashboard pybind tests

Projects

Ceph-Dashboard
Archived in project

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@nizamial09 @epuertat