squid: mon,cephfs: require confirmation when changing max_mds on unhealthy cluster#60398
Conversation
12667c0 to
ea1fe58
Compare
Thank you for the review! |
|
This PR is under test in https://tracker.ceph.com/issues/68851. |
|
This pull request has been automatically marked as stale because it has not had any activity for 60 days. It will be closed if no further activity occurs for another 30 days. |
|
This pull request has been automatically closed because there has been no activity for 90 days. Please feel free to reopen this pull request (or open a new one) if the proposed change is still appropriate. Thank you for your contribution! |
|
This pull request can no longer be automatically merged: a rebase is needed and changes have to be manually resolved |
|
@rishabh-d-dave please rebase this |
…luster User must pass the confirmation flag (--yes-i-really-mean-it) to change the value of CephFS setting variable "max_mds" when the Ceph cluster is unhealthy. This measure was decided upon to prevent users from changing "max_mds" as a measure of troubleshotoing unhealthy cluster. Fixes: https://tracker.ceph.com/issues/66301 Signed-off-by: Rishabh Dave <ridave@redhat.com> (cherry picked from commit a55a75c) Conflicts: src/mon/FSCommands.cc - Method set_val() in present in this file in main branch but it's absent in Squid branch.
Add tests to ensure that when cluster has any health warning, especially MDS_TRIM, confirmation flag is mandatory to change max_mds. Signed-off-by: Rishabh Dave <ridave@redhat.com> (cherry picked from commit 4d5ec87) Conflicts: qa/tasks/cephfs/test_admin.py - This file is bit different than main branch version which led to conflict in applying the patch in this commit.
Update the documentation for CephFs admininstration as well troubleshooting. Signed-off-by: Rishabh Dave <ridave@redhat.com> (cherry picked from commit 2d28faa) Conflicts: doc/cephfs/troubleshooting.rst - This patch was skipped because it was (erroneously) included by a different PR author in its PR.
ea1fe58 to
90632e5
Compare
@kotreshhr Done. |
|
jenkins test api |
|
@joscollin All CI jobs passed. |
|
This PR is under test in https://tracker.ceph.com/issues/73330. |
Add a release note for the fact that users now need to pass the confirmation flag for modifying "max_mds" when cluster is unhealthy. Signed-off-by: Rishabh Dave <ridave@redhat.com> (cherry picked from commit a71c8e8)
backport tracker: https://tracker.ceph.com/issues/68621
backport of #59420
parent tracker: https://tracker.ceph.com/issues/66301
this backport was staged using ceph-backport.sh version 16.0.0.6848
find the latest version at https://github.com/ceph/ceph/blob/main/src/script/ceph-backport.sh