os/bluestore: Create additional bdev labels when expanding block device.#60363
os/bluestore: Create additional bdev labels when expanding block device.#60363
Conversation
There was a problem when expansion of 'block' device crossed location of bdev label copy. The extra label that did not exist before and now exists was not initialized. This makes test to fail. Signed-off-by: Adam Kupczyk <akupczyk@ibm.com>
There was a problem when expansion of 'block' device crossed location of bdev label copy. The extra label that did not exist before and now exist was not initialized. Also changed logic of 'bluestore_bdev_label_require_all'. Previously label locations 0..bdev->size() were taken in to account. Now labels in range bdev_label.size..bdev->size() are excluded. Fixes: https://tracker.ceph.com/issues/68577 Signed-off-by: Adam Kupczyk <akupczyk@ibm.com>
|
ceph test api |
|
jenkins test api |
|
This pull request has been automatically marked as stale because it has not had any activity for 60 days. It will be closed if no further activity occurs for another 30 days. |
|
Hey @aclamk, while evaluating the QA run that included this PR, I found an error which seems to be related to this PR. I've created a ticket with my findings here: https://tracker.ceph.com/issues/69691. Could you please check the same? |
When expansion crosses potential location of multi bdev label, we need to initialize the new label.
https://tracker.ceph.com/issues/68577
In case of backport, #61470 is also needed.
Contribution Guidelines
To sign and title your commits, please refer to Submitting Patches to Ceph.
If you are submitting a fix for a stable branch (e.g. "quincy"), please refer to Submitting Patches to Ceph - Backports for the proper workflow.
When filling out the below checklist, you may click boxes directly in the GitHub web UI. When entering or editing the entire PR message in the GitHub web UI editor, you may also select a checklist item by adding an
xbetween the brackets:[x]. Spaces and capitalization matter when checking off items this way.Checklist
Show available Jenkins commands
jenkins retest this pleasejenkins test classic perfjenkins test crimson perfjenkins test signedjenkins test make checkjenkins test make check arm64jenkins test submodulesjenkins test dashboardjenkins test dashboard cephadmjenkins test apijenkins test docsjenkins render docsjenkins test ceph-volume alljenkins test ceph-volume toxjenkins test windowsjenkins test rook e2e