Skip to content

mds/Beacon: wake up the thread in shutdown()#60325

Merged
batrick merged 1 commit intoceph:mainfrom
MaxKellermann:Beacon_wakeup
Nov 13, 2024
Merged

mds/Beacon: wake up the thread in shutdown()#60325
batrick merged 1 commit intoceph:mainfrom
MaxKellermann:Beacon_wakeup

Conversation

@MaxKellermann
Copy link
Member

@MaxKellermann MaxKellermann commented Oct 15, 2024 •
edited
Loading

This eliminates the wait_for() delay and speeds up MDS shutdown.

This used to be part of #60320

Checklist

  • Tracker (select at least one)
    • References tracker ticket
    • Very recent bug; references commit where it was introduced
    • New feature (ticket optional)
    • Doc update (no ticket needed)
    • Code cleanup (no ticket needed)
  • Component impact
    • Affects Dashboard, opened tracker ticket
    • Affects Orchestrator, opened tracker ticket
    • No impact that needs to be tracked
  • Documentation (select at least one)
    • Updates relevant documentation
    • No doc update is appropriate
  • Tests (select at least one)

@github-actions github-actions bot added the cephfs Ceph File System label Oct 15, 2024
@batrick
Copy link
Member

batrick commented Oct 16, 2024

jenkins test api

@batrick
Copy link
Member

batrick commented Oct 16, 2024

jenkins test make check arm64

@batrick
Copy link
Member

batrick commented Oct 16, 2024

I'd also approve a ticket for backporting this.

@batrick
Copy link
Member

batrick commented Oct 22, 2024

jenkins test api

vshankar
vshankar approved these changes Oct 28, 2024
View reviewed changes
Copy link
Contributor

@vshankar vshankar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@MaxKellermann please create a redmine ticket and link it in the commit message. Thx!

@vshankar vshankar self-assigned this Oct 28, 2024
@MaxKellermann
Copy link
Member Author

MaxKellermann commented Oct 28, 2024

OK, I have registered an account and waiting for approval. Then I'll create tickets for several other PRs.

@MaxKellermann
Copy link
Member Author

MaxKellermann commented Oct 29, 2024

https://tracker.ceph.com/issues/68759

@MaxKellermann
mds/Beacon: wake up the thread in shutdown()
0276ab4 
This eliminates the `wait_for()` delay and speeds up MDS shutdown.

Fixes: https://tracker.ceph.com/issues/68759
Signed-off-by: Max Kellermann <max.kellermann@ionos.com>
@batrick
Copy link
Member

batrick commented Oct 31, 2024

This PR is under test in https://tracker.ceph.com/issues/68786.

@batrick
Copy link
Member

batrick commented Nov 6, 2024

This PR is under test in https://tracker.ceph.com/issues/68859.

@batrick
Copy link
Member

batrick commented Nov 13, 2024

https://tracker.ceph.com/issues/68859#note-2

@batrick batrick merged commit ad153a8 into ceph:main Nov 13, 2024
@vshankar vshankar mentioned this pull request Nov 26, 2024
Merged
@mchangir mchangir mentioned this pull request Jan 25, 2025
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@vshankar vshankar vshankar approved these changes

@batrick batrick batrick approved these changes

Assignees

@vshankar vshankar

Labels

cephfs Ceph File System needs-qa wip-pdonnell-testing

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@MaxKellermann @batrick @vshankar