Skip to content

rgw_cksum: treat mpu checksums w/o part count as valid in CompleteMu…#60309

Merged
cbodley merged 1 commit intoceph:mainfrom
linuxbox2:wip-cksum-68537
Nov 18, 2024
Merged

rgw_cksum: treat mpu checksums w/o part count as valid in CompleteMu…#60309
cbodley merged 1 commit intoceph:mainfrom
linuxbox2:wip-cksum-68537

Conversation

@mattbenjamin
Copy link
Copy Markdown
Contributor

@mattbenjamin mattbenjamin commented Oct 14, 2024

…ltipart

Apparently, AWS accepts this and Minio's current golang SDK relies on it.

Fixes: https://tracker.ceph.com/issues/68537

Contribution Guidelines

  • To sign and title your commits, please refer to Submitting Patches to Ceph.

  • If you are submitting a fix for a stable branch (e.g. "quincy"), please refer to Submitting Patches to Ceph - Backports for the proper workflow.

  • When filling out the below checklist, you may click boxes directly in the GitHub web UI. When entering or editing the entire PR message in the GitHub web UI editor, you may also select a checklist item by adding an x between the brackets: [x]. Spaces and capitalization matter when checking off items this way.

Checklist

  • Tracker (select at least one)
    • References tracker ticket
    • Very recent bug; references commit where it was introduced
    • New feature (ticket optional)
    • Doc update (no ticket needed)
    • Code cleanup (no ticket needed)
  • Component impact
    • Affects Dashboard, opened tracker ticket
    • Affects Orchestrator, opened tracker ticket
    • No impact that needs to be tracked
  • Documentation (select at least one)
    • Updates relevant documentation
    • No doc update is appropriate
  • Tests (select at least one)
Show available Jenkins commands
  • jenkins retest this please
  • jenkins test classic perf
  • jenkins test crimson perf
  • jenkins test signed
  • jenkins test make check
  • jenkins test make check arm64
  • jenkins test submodules
  • jenkins test dashboard
  • jenkins test dashboard cephadm
  • jenkins test api
  • jenkins test docs
  • jenkins render docs
  • jenkins test ceph-volume all
  • jenkins test ceph-volume tox
  • jenkins test windows
  • jenkins test rook e2e

…tipart

Apparently, AWS accepts this and Minio's current golang SDK relies
on it.

Fixes: https://tracker.ceph.com/issues/68537

Signed-off-by: Matt Benjamin <mbenjamin@redhat.com>
@mattbenjamin mattbenjamin self-assigned this Oct 14, 2024
@mattbenjamin mattbenjamin requested a review from a team as a code owner October 14, 2024 20:59
@mattbenjamin mattbenjamin requested a review from cbodley October 14, 2024 21:01
@mattbenjamin
Copy link
Copy Markdown
Contributor Author

@mattbenjamin
Copy link
Copy Markdown
Contributor Author

so this is a pass, there are 5 instances of a segfault in RGWPSListTopicsOp::execute(optional_yield)+0x13f), but it occurs after 99% of s3-tests have completed without issues (we should fix that)
failures:

  1. http://qa-proxy.ceph.com/teuthology/mbenjamin-2024-11-17_14:25:09-rgw-wip-cksum-68513-68537-distro-default-smithi/7995891/teuthology.log passed 99%, failed w/known issue: 2024-11-17T15:22:30.259 INFO:tasks.rgw.client.0.smithi052.stdout: 2: (RGWPSListTopicsOp::execute(optional_yield)+0x13f) [0x561492b3358f]
  2. http://qa-proxy.ceph.com/teuthology/mbenjamin-2024-11-17_14:25:09-rgw-wip-cksum-68513-68537-distro-default-smithi/7995900/teuthology.log : multisite test failures
  3. http://qa-proxy.ceph.com/teuthology/mbenjamin-2024-11-17_14:25:09-rgw-wip-cksum-68513-68537-distro-default-smithi/7995910/teuthology.log : also known issue (RGWPSListTopicsOp::execute(optional_yield)+0x13f)
  4. https://pulpito.ceph.com/mbenjamin-2024-11-17_14:25:09-rgw-wip-cksum-68513-68537-distro-default-smithi/7995914/ : failure in ceph-mgr
  5. http://qa-proxy.ceph.com/teuthology/mbenjamin-2024-11-17_14:25:09-rgw-wip-cksum-68513-68537-distro-default-smithi/7995915/teuthology.log : also reproducing the segfault in RGWPSListTopicsOp::execute(optional_yield)+0x13f)
  6. http://qa-proxy.ceph.com/teuthology/mbenjamin-2024-11-17_14:25:09-rgw-wip-cksum-68513-68537-distro-default-smithi/7995928/teuthology.log : also reproducing the segfault in RGWPSListTopicsOp::execute(optional_yield)+0x13f)

@cbodley cbodley merged commit 8bea3af into ceph:main Nov 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants