mds: return as early as possible from CDir::should_split_fast()#60236
Merged
mds: return as early as possible from CDir::should_split_fast()#60236
Conversation
f84c7a0 to
8187794
Compare
Member
Author
|
Added an |
vshankar
reviewed
Oct 16, 2024
vshankar
approved these changes
Oct 16, 2024
Contributor
|
This PR is under test in https://tracker.ceph.com/issues/68578. |
All we want to know is whether we're above the `fast_limit`; if we're above that, we don't need to know how many exactly. By returning early instead of iterating over all entries, a lot of CPU time can be saved. In a microbenchmark where `fio` was used to create thousands of files, the CPU usage of `CDir::should_split_fast()` went from 6% to less than 1% in the `perf report`. Signed-off-by: Max Kellermann <max.kellermann@ionos.com>
8187794 to
27feea1
Compare
vshankar
approved these changes
Oct 30, 2024
Contributor
|
jenkins retest this please |
Contributor
|
jenkins test make check |
dparmar18
approved these changes
Oct 30, 2024
Member
|
jenkins test make check |
batrick
approved these changes
Oct 31, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
All we want to know is whether we're above the
fast_limit; if we're above that, we don't need to know how many exactly.Checklist