mds/QuiesceDbEncoding: add inline to work around linker error#60226
Merged
mds/QuiesceDbEncoding: add inline to work around linker error#60226
inline to work around linker error#60226Conversation
Fixes duplicate symbols because every source that includes this header contains a copy: mold: error: duplicate symbol: lib/libceph-common.a(Message.cc.o): lib/libmds.a(MDSRankQuiesce.cc.o): encode(QuiesceDbVersion const&, ceph::buffer::v15_2_0::list&, unsigned long) mold: error: duplicate symbol: lib/libceph-common.a(Message.cc.o): lib/libmds.a(MDSRankQuiesce.cc.o): encode(QuiesceState const&, ceph::buffer::v15_2_0::list&, unsigned long) (and many more) Signed-off-by: Max Kellermann <max.kellermann@ionos.com>
2d22815 to
1a85d4d
Compare
Contributor
|
jenkins test api |
batrick
approved these changes
Oct 31, 2024
Member
|
This PR is under test in https://tracker.ceph.com/issues/68859. |
rishabh-d-dave
approved these changes
Nov 12, 2024
Contributor
There was a problem hiding this comment.
LGTM but @batrick won't it be nice to backport this small change? It would serve two purposes: fix warning for older releases as well as ensure future backport PRs don't have to hit and resolve a conflict due to absence backporting of this patch.
Member
Member
Yes, generally. But it's not necessary (IMO) if it's not breaking release branches for our testing purposes. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes duplicate symbols because every source that includes this header contains a copy:
(and many more)
Checklist