Skip to content

os/bluestore: make retry_max and initial_delay configurable for aio s…#60205

Merged
SrinivasaBharath merged 1 commit intoceph:mainfrom
Rethan:bluestore-aio-submit-retries
Feb 19, 2025
Merged

os/bluestore: make retry_max and initial_delay configurable for aio s…#60205
SrinivasaBharath merged 1 commit intoceph:mainfrom
Rethan:bluestore-aio-submit-retries

Conversation

@Rethan
Copy link
Contributor

@Rethan Rethan commented Oct 9, 2024

…ubmit_batch

Default aio submit retry (times and delay) sometimes is not enough for e.g. high density hdd osd under pressure.

Contribution Guidelines

  • To sign and title your commits, please refer to Submitting Patches to Ceph.

  • If you are submitting a fix for a stable branch (e.g. "quincy"), please refer to Submitting Patches to Ceph - Backports for the proper workflow.

  • When filling out the below checklist, you may click boxes directly in the GitHub web UI. When entering or editing the entire PR message in the GitHub web UI editor, you may also select a checklist item by adding an x between the brackets: [x]. Spaces and capitalization matter when checking off items this way.

Checklist

  • Tracker (select at least one)
    • References tracker ticket
    • Very recent bug; references commit where it was introduced
    • New feature (ticket optional)
    • Doc update (no ticket needed)
    • Code cleanup (no ticket needed)
  • Component impact
    • Affects Dashboard, opened tracker ticket
    • Affects Orchestrator, opened tracker ticket
    • No impact that needs to be tracked
  • Documentation (select at least one)
    • Updates relevant documentation
    • No doc update is appropriate
  • Tests (select at least one)
Show available Jenkins commands
  • jenkins retest this please
  • jenkins test classic perf
  • jenkins test crimson perf
  • jenkins test signed
  • jenkins test make check
  • jenkins test make check arm64
  • jenkins test submodules
  • jenkins test dashboard
  • jenkins test dashboard cephadm
  • jenkins test api
  • jenkins test docs
  • jenkins render docs
  • jenkins test ceph-volume all
  • jenkins test ceph-volume tox
  • jenkins test windows
  • jenkins test rook e2e

@Rethan Rethan requested a review from a team as a code owner October 9, 2024 06:30
@Rethan
Copy link
Contributor Author

Rethan commented Oct 9, 2024

image

@github-actions
Copy link

This pull request has been automatically marked as stale because it has not had any activity for 60 days. It will be closed if no further activity occurs for another 30 days.
If you are a maintainer or core committer, please follow-up on this pull request to identify what steps should be taken by the author to move this proposed change forward.
If you are the author of this pull request, thank you for your proposed contribution. If you believe this change is still appropriate, please ensure that any feedback has been addressed and ask for a code review.

@github-actions github-actions bot added the stale label Dec 22, 2024
@github-actions
Copy link

This pull request has been automatically closed because there has been no activity for 90 days. Please feel free to reopen this pull request (or open a new one) if the proposed change is still appropriate. Thank you for your contribution!

@github-actions github-actions bot closed this Jan 21, 2025
@ifed01 ifed01 reopened this Jan 21, 2025
@github-actions github-actions bot removed the stale label Jan 21, 2025
@SrinivasaBharath
Copy link
Contributor

jenkins test make check arm64

@SrinivasaBharath
Copy link
Contributor

@Rethan Please resolve the pull request checklist failure.

…ubmit_batch

Default aio submit retry (times and delay) sometimes is not enough for e.g. high density hdd osd under pressure.

Signed-off-by: haoyixing <haoyixing@kuaishou.com>
@Rethan Rethan force-pushed the bluestore-aio-submit-retries branch from c181507 to 3667f4a Compare February 11, 2025 02:25
@Rethan
Copy link
Contributor Author

Rethan commented Feb 11, 2025

jenkins test make check

@Rethan
Copy link
Contributor Author

Rethan commented Feb 11, 2025

@Rethan Please resolve the pull request checklist failure.
@SrinivasaBharath Make checks have passed after retry.

@ljflores
Copy link
Member

@SrinivasaBharath SrinivasaBharath merged commit e0e3dc9 into ceph:main Feb 19, 2025
13 checks passed
@Rethan Rethan deleted the bluestore-aio-submit-retries branch February 24, 2025 02:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants