Skip to content

reef: cephfs_mirror, qa: fix test failure test_cephfs_mirror_cancel_mirroring_and_readd#60182

Merged
hkadam134 merged 2 commits intoceph:reeffrom
joscollin:wip-68409-reef
Nov 28, 2024
Merged

reef: cephfs_mirror, qa: fix test failure test_cephfs_mirror_cancel_mirroring_and_readd#60182
hkadam134 merged 2 commits intoceph:reeffrom
joscollin:wip-68409-reef

Conversation

@joscollin
Copy link
Member

backport tracker: https://tracker.ceph.com/issues/68409


backport of #56118
parent tracker: https://tracker.ceph.com/issues/64711

this backport was staged using ceph-backport.sh version 16.0.0.6848
find the latest version at https://github.com/ceph/ceph/blob/main/src/script/ceph-backport.sh

…_mirror_cancel_mirroring_and_readd execution

Avoid stale fh by calling pre_sync_check_and_open_handles inside the loop

Fixes: https://tracker.ceph.com/issues/65115
Signed-off-by: Jos Collin <jcollin@redhat.com>
(cherry picked from commit bd78bdc)
* Make all replayer threads busy and then query for 'syncing' state
instead of just fetching the current status.

* Dropped 'current_syncing_snap' check, as it's not compulsory for
this test. The actual intension is to make threads in 'syncing' status
and 'current_syncing_snap' check is not necessary for that.

* Drop 'snaps_deleted' metrics check in test_cephfs_mirror_cancel_mirroring_and_readd.
test_cephfs_mirror_cancel_mirroring_and_readd primarily focusses
on the synchronization of the newly added directory paths post removal
of the previously added/syncing directory paths. So checking of 'snaps_deleted'
metrics is unnecessary here.

* Wait for more time to finish the new snapshot creations and the sync backoff.
We need to wait for more time in test_cephfs_mirror_cancel_mirroring_and_readd,
as the test makes all replayer threads busy.

Fixes: https://tracker.ceph.com/issues/64711
Signed-off-by: Jos Collin <jcollin@redhat.com>
(cherry picked from commit db9825d)
@joscollin joscollin added this to the reef milestone Oct 8, 2024
@joscollin joscollin added the cephfs Ceph File System label Oct 8, 2024
@github-actions github-actions bot added the tests label Oct 8, 2024
@joscollin joscollin requested a review from a team October 8, 2024 10:40
@joscollin
Copy link
Member Author

@vshankar ping, for review and testing of this backport. I got a ping from Igor Fedotov he's hitting this issue in v18.2.4.

@vshankar
Copy link
Contributor

vshankar commented Nov 6, 2024

@vshankar ping, for review and testing of this backport. I got a ping from Igor Fedotov he's hitting this issue in v18.2.4.

Noted. Will have a look.

Copy link
Member Author

@joscollin joscollin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The test passed: https://pulpito.ceph.com/hyelloji-2024-11-08_10:25:54-fs:mirror-wip-hemanth-testing-2024-11-07-0912-reef-distro-default-smithi/.

This PR is tested without having snapdiff incremental sync. @hkadam134 suggest you to retest with snapdiff incremental sync in your branch.

@hkadam134
Copy link
Contributor

The test passed: https://pulpito.ceph.com/hyelloji-2024-11-08_10:25:54-fs:mirror-wip-hemanth-testing-2024-11-07-0912-reef-distro-default-smithi/.

This PR is tested without having snapdiff incremental sync. @hkadam134 suggest you to retest with snapdiff incremental sync in your branch.

@joscollin - Here is the rerun Test results - https://pulpito.ceph.com/hyelloji-2024-11-25_10:48:00-fs:mirror-wip-hemanth-testing-2024-11-25-0737-reef-distro-default-smithi/

Copy link
Member Author

@joscollin joscollin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@hkadam134 I've checked the test results. Looks good to me. Please merge this.

@hkadam134 hkadam134 self-requested a review November 28, 2024 17:01
Copy link
Contributor

@hkadam134 hkadam134 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@hkadam134 hkadam134 merged commit f229634 into ceph:reef Nov 28, 2024
@joscollin joscollin deleted the wip-68409-reef branch November 29, 2024 01:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants