reef: cephfs_mirror, qa: fix test failure test_cephfs_mirror_cancel_mirroring_and_readd#60182
reef: cephfs_mirror, qa: fix test failure test_cephfs_mirror_cancel_mirroring_and_readd#60182
Conversation
…_mirror_cancel_mirroring_and_readd execution Avoid stale fh by calling pre_sync_check_and_open_handles inside the loop Fixes: https://tracker.ceph.com/issues/65115 Signed-off-by: Jos Collin <jcollin@redhat.com> (cherry picked from commit bd78bdc)
* Make all replayer threads busy and then query for 'syncing' state instead of just fetching the current status. * Dropped 'current_syncing_snap' check, as it's not compulsory for this test. The actual intension is to make threads in 'syncing' status and 'current_syncing_snap' check is not necessary for that. * Drop 'snaps_deleted' metrics check in test_cephfs_mirror_cancel_mirroring_and_readd. test_cephfs_mirror_cancel_mirroring_and_readd primarily focusses on the synchronization of the newly added directory paths post removal of the previously added/syncing directory paths. So checking of 'snaps_deleted' metrics is unnecessary here. * Wait for more time to finish the new snapshot creations and the sync backoff. We need to wait for more time in test_cephfs_mirror_cancel_mirroring_and_readd, as the test makes all replayer threads busy. Fixes: https://tracker.ceph.com/issues/64711 Signed-off-by: Jos Collin <jcollin@redhat.com> (cherry picked from commit db9825d)
|
@vshankar ping, for review and testing of this backport. I got a ping from Igor Fedotov he's hitting this issue in v18.2.4. |
Noted. Will have a look. |
joscollin
left a comment
There was a problem hiding this comment.
The test passed: https://pulpito.ceph.com/hyelloji-2024-11-08_10:25:54-fs:mirror-wip-hemanth-testing-2024-11-07-0912-reef-distro-default-smithi/.
This PR is tested without having snapdiff incremental sync. @hkadam134 suggest you to retest with snapdiff incremental sync in your branch.
@joscollin - Here is the rerun Test results - https://pulpito.ceph.com/hyelloji-2024-11-25_10:48:00-fs:mirror-wip-hemanth-testing-2024-11-25-0737-reef-distro-default-smithi/ |
joscollin
left a comment
There was a problem hiding this comment.
@hkadam134 I've checked the test results. Looks good to me. Please merge this.
backport tracker: https://tracker.ceph.com/issues/68409
backport of #56118
parent tracker: https://tracker.ceph.com/issues/64711
this backport was staged using ceph-backport.sh version 16.0.0.6848
find the latest version at https://github.com/ceph/ceph/blob/main/src/script/ceph-backport.sh