mgr/vol: add comments to explain queuing data structures#60119
Merged
rishabh-d-dave merged 1 commit intoceph:mainfrom Oct 24, 2024
Merged
mgr/vol: add comments to explain queuing data structures#60119rishabh-d-dave merged 1 commit intoceph:mainfrom
rishabh-d-dave merged 1 commit intoceph:mainfrom
Conversation
Contributor
Author
|
This PR is under test in https://tracker.ceph.com/issues/68395. |
vshankar
reviewed
Oct 4, 2024
63ce918 to
5bbfe13
Compare
5bbfe13 to
46bf971
Compare
Contributor
Author
|
This PR is under test in https://tracker.ceph.com/issues/68419. |
joscollin
reviewed
Oct 8, 2024
| threading.Thread.__init__(self, name="{0}.tick".format(name_pfx)) | ||
| self.vc = volume_client | ||
| # queue of volumes for starting async jobs | ||
| # deque where each member is a string and where each string is name of |
Contributor
Author
There was a problem hiding this comment.
Updated. I've kept it a bit verbose so future readers don't have to guess.
Add some comment to explains the purpose and details of data structures that are used for queuing of async jobs since right now it's not obvious from initialization. Signed-off-by: Rishabh Dave <ridave@redhat.com>
46bf971 to
8f7c5f0
Compare
joscollin
approved these changes
Oct 21, 2024
rishabh-d-dave
commented
Oct 24, 2024
Contributor
Author
rishabh-d-dave
left a comment
There was a problem hiding this comment.
QA run was successful - https://tracker.ceph.com/projects/cephfs/wiki/Main#wip-rishabh-testing-20241007102024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add some comment to explains the purpose and details of data structures
that are used for queuing of async jobs since right now it's not obvious
from initialization.
Contribution Guidelines
To sign and title your commits, please refer to Submitting Patches to Ceph.
If you are submitting a fix for a stable branch (e.g. "quincy"), please refer to Submitting Patches to Ceph - Backports for the proper workflow.
When filling out the below checklist, you may click boxes directly in the GitHub web UI. When entering or editing the entire PR message in the GitHub web UI editor, you may also select a checklist item by adding an
xbetween the brackets:[x]. Spaces and capitalization matter when checking off items this way.Checklist
Show available Jenkins commands
jenkins retest this pleasejenkins test classic perfjenkins test crimson perfjenkins test signedjenkins test make checkjenkins test make check arm64jenkins test submodulesjenkins test dashboardjenkins test dashboard cephadmjenkins test apijenkins test docsjenkins render docsjenkins test ceph-volume alljenkins test ceph-volume toxjenkins test windowsjenkins test rook e2e