mgr/vol: don't define progress bar ID repeatedly#60027
Merged
rishabh-d-dave merged 1 commit intoceph:mainfrom Oct 18, 2024
Merged
mgr/vol: don't define progress bar ID repeatedly#60027rishabh-d-dave merged 1 commit intoceph:mainfrom
rishabh-d-dave merged 1 commit intoceph:mainfrom
Conversation
Orignally, when the feature was in development, IDs for clone progress bars were set to randomly generated UUID strings. But, eventually, it was decided to assign fixed strings to them. Unlike UUIDs, these strings stay the same even when progress bars are destroyed and re-created. Therefore, instead of re-assigning the same strings every time initiate_reporting() is called, move them to __init__() so that both the IDs are defined only once. Signed-off-by: Rishabh Dave <ridave@redhat.com>
Contributor
Author
|
jenkins test api |
Contributor
Author
|
jenkins test windows |
Contributor
Author
|
jenkins test mak check arm64 |
Contributor
Author
|
jenkins test make check arm64 |
Contributor
Author
|
This PR is under test in https://tracker.ceph.com/issues/68354. |
Contributor
Author
|
jenkins test make check arm64 |
batrick
reviewed
Oct 3, 2024
| self.update_task = RTimer(1, self._update_progress_bars) | ||
|
|
||
| # progress event ID for ongoing clone jobs | ||
| self.on_pev_id: Optional[str] = 'mgr-vol-ongoing-clones' |
Member
There was a problem hiding this comment.
does it need to be Optional if we're not going to assign None?
Contributor
Author
There was a problem hiding this comment.
Yes, else mypy throws a warning otherwise which causes make check to fail
vshankar
approved these changes
Oct 18, 2024
Contributor
vshankar
left a comment
There was a problem hiding this comment.
Approving based on @rishabh-d-dave mentioning that the tests have been run and verified. @rishabh-d-dave please share the run wiki link.
Contributor
Author
|
QA run was successful - https://tracker.ceph.com/projects/cephfs/wiki/Main#2024-Oct-18 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Orignally, when the feature was in development, IDs for clone progress
bars were set to randomly generated UUID strings. But, eventually, it
was decided to assign fixed strings to them. Unlike UUIDs, these strings
stay the same even when progress bars are destroyed and re-created.
Therefore, instead of re-assigning the same strings every time
initiate_reporting() is called, move them to init() so that both the
IDs are defined only once.
Contribution Guidelines
To sign and title your commits, please refer to Submitting Patches to Ceph.
If you are submitting a fix for a stable branch (e.g. "quincy"), please refer to Submitting Patches to Ceph - Backports for the proper workflow.
When filling out the below checklist, you may click boxes directly in the GitHub web UI. When entering or editing the entire PR message in the GitHub web UI editor, you may also select a checklist item by adding an
xbetween the brackets:[x]. Spaces and capitalization matter when checking off items this way.Checklist
Show available Jenkins commands
jenkins retest this pleasejenkins test classic perfjenkins test crimson perfjenkins test signedjenkins test make checkjenkins test make check arm64jenkins test submodulesjenkins test dashboardjenkins test dashboard cephadmjenkins test apijenkins test docsjenkins render docsjenkins test ceph-volume alljenkins test ceph-volume toxjenkins test windowsjenkins test rook e2e