Skip to content

rgw: decrypt multipart get part when encrypted#60019

Merged
cbodley merged 1 commit intoceph:mainfrom
sungjoon-koh:fix-get-part-number
Oct 4, 2024
Merged

rgw: decrypt multipart get part when encrypted#60019
cbodley merged 1 commit intoceph:mainfrom
sungjoon-koh:fix-get-part-number

Conversation

@sungjoon-koh
Copy link
Copy Markdown
Contributor

@sungjoon-koh sungjoon-koh commented Sep 27, 2024 •
edited
Loading

If the multipart object is encrypted by SSE-C or SSE-S3, get object with partNumber doesn't decrypt the part.

This patch enables rgw to decrypt the part for get object request with partNumber.

Contribution Guidelines

  • To sign and title your commits, please refer to Submitting Patches to Ceph.

  • If you are submitting a fix for a stable branch (e.g. "quincy"), please refer to Submitting Patches to Ceph - Backports for the proper workflow.

  • When filling out the below checklist, you may click boxes directly in the GitHub web UI. When entering or editing the entire PR message in the GitHub web UI editor, you may also select a checklist item by adding an x between the brackets: [x]. Spaces and capitalization matter when checking off items this way.

Checklist

  • Tracker (select at least one)
    • References tracker ticket
    • Very recent bug; references commit where it was introduced
    • New feature (ticket optional)
    • Doc update (no ticket needed)
    • Code cleanup (no ticket needed)
  • Component impact
    • Affects Dashboard, opened tracker ticket
    • Affects Orchestrator, opened tracker ticket
    • No impact that needs to be tracked
  • Documentation (select at least one)
    • Updates relevant documentation
    • No doc update is appropriate
  • Tests (select at least one)
Show available Jenkins commands
  • jenkins retest this please
  • jenkins test classic perf
  • jenkins test crimson perf
  • jenkins test signed
  • jenkins test make check
  • jenkins test make check arm64
  • jenkins test submodules
  • jenkins test dashboard
  • jenkins test dashboard cephadm
  • jenkins test api
  • jenkins test docs
  • jenkins render docs
  • jenkins test ceph-volume all
  • jenkins test ceph-volume tox
  • jenkins test windows
  • jenkins test rook e2e

@sungjoon-koh sungjoon-koh requested a review from a team as a code owner September 27, 2024 07:38
@github-actions github-actions bot added the rgw label Sep 27, 2024
@sungjoon-koh
Copy link
Copy Markdown
Contributor Author

sungjoon-koh commented Sep 27, 2024

@cbodley Hello, could you please check this PR?

@sungjoon-koh
Copy link
Copy Markdown
Contributor Author

sungjoon-koh commented Sep 27, 2024

To reproduce:

  1. Enable SSE-S3 (add following line to vstart.sh)
    rgw crypt default encryption key = 4YSmvJtBv0aZ7geVgAsdpRnLBEwWSWlMIGnRS8a9TSA=
  2. Create multipart, upload part, and complete multipart upload.
  3. Get object with part number.
    aws s3api get-object --bucket $BUCKET --key $KEY --part-number 1 test-part-1

--> You can get encrypted part.

cbodley
cbodley reviewed Sep 27, 2024
View reviewed changes
Copy link
Copy Markdown
Contributor

@cbodley cbodley left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks @sungjoon-koh! i've created https://tracker.ceph.com/issues/68292 to track the backport to squid

@adamemerson
Copy link
Copy Markdown
Contributor

adamemerson commented Sep 27, 2024

jenkins test windows

@cbodley cbodley mentioned this pull request Sep 27, 2024
Merged
@cbodley
Copy link
Copy Markdown
Contributor

cbodley commented Sep 27, 2024

i added a sse-c test case for this in ceph/s3-tests#591

@sungjoon-koh
Copy link
Copy Markdown
Contributor Author

sungjoon-koh commented Sep 28, 2024

@cbodley Thank you for your prompt response. I addressed your comment.
I also checked with your test.

@sungjoon-koh
Copy link
Copy Markdown
Contributor Author

sungjoon-koh commented Sep 30, 2024

jenkins test api

cbodley
cbodley reviewed Sep 30, 2024
View reviewed changes
@sungjoon-koh
rgw: decrypt multipart get part when encrypted
b8516bf 
Copy crypt related attrs for get object with partNumber

Signed-off-by: sungjoon-koh <sungjoon_koh@linecorp.com>
@sungjoon-koh
Copy link
Copy Markdown
Contributor Author

sungjoon-koh commented Oct 1, 2024

jenkins test windows

@cbodley
Copy link
Copy Markdown
Contributor

cbodley commented Oct 4, 2024

passed qa in https://pulpito.ceph.com/cbodley-2024-10-04_16:44:30-rgw-wip-68292-distro-default-smithi/ against test cases from ceph/s3-tests#591:

s3tests_boto3/functional/test_s3.py::test_multipart_get_part PASSED      [ 67%]
s3tests_boto3/functional/test_s3.py::test_multipart_sse_c_get_part PASSED [ 67%]
s3tests_boto3/functional/test_s3.py::test_multipart_single_get_part PASSED [ 68%]
s3tests_boto3/functional/test_s3.py::test_non_multipart_get_part PASSED  [ 68%]
s3tests_boto3/functional/test_s3.py::test_non_multipart_sse_c_get_part PASSED [ 68%]

@cbodley cbodley merged commit f239e22 into ceph:main Oct 4, 2024
@cbodley cbodley mentioned this pull request Oct 4, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@cbodley cbodley cbodley approved these changes

Assignees

No one assigned

Labels

bug-fix needs-qa rgw wip-cbodley-testing

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@sungjoon-koh @adamemerson @cbodley