qa/standalone/scrub: increase status updates frequency#59944
Merged
qa/standalone/scrub: increase status updates frequency#59944
Conversation
To prevent test timeouts. Also - remove a failing assertion on a specific 'pg query' output, as it is not central to the test. Fixes: https://tracker.ceph.com/issues/61385 Fixes: https://tracker.ceph.com/issues/64346 Signed-off-by: Ronen Friedman <rfriedma@redhat.com>
rzarzynski
reviewed
Sep 24, 2024
| declare -A cond_active_dmp=( ['dmp_state_has_scrubbing']="true" ['query_active']="false" ) | ||
| sched_data=() | ||
| wait_any_cond $pgid 10 $saved_last_stamp cond_active_dmp "WaitingActive " sched_data || return 1 | ||
| wait_any_cond $pgid 10 $saved_last_stamp cond_active_dmp "WaitingActive " sched_data |
Contributor
There was a problem hiding this comment.
After the fix we don't return if wait_any_cond fails. Is this intentional?
Contributor
Author
There was a problem hiding this comment.
Yes. That test is flaky, and I still don't know why. It might be just a synchronization issue, and the manager
parameter seems to help, but I am not sure that is all.
As this problem affects many runs, and especially my testing, I prefer to have this line fail without failing the test.
I'll have to find a better fix after all other related scrub changes settle.
Contributor
Author
|
jenkins test api |
rzarzynski
approved these changes
Sep 24, 2024
This was referenced Oct 1, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
To prevent test timeouts.
Also - remove a failing assertion on a specific 'pg query' output, as it is not central to the test.
Fixes: https://tracker.ceph.com/issues/61385
Fixes: https://tracker.ceph.com/issues/64346