librbd: introduce rbd_group_snap_namespace_type_t enum #59883
Conversation
|
This is a follow up for #57797, awaited by ceph/go-ceph#1025. |
|
jenkins test make check |
|
The rbd group snap info command should also display the snap namespace information. |
Commit e5ccce1 ("rbd: add group snap info command") added a commented out field in rbd_group_snap_info2_t struct but didn't define the corresponding enum, expecting it to be brought in with the patchset that introduces mirror group snapshots. That work is still in progress, but there is already interest in the new command and APIs that use rbd_group_snap_info2_t struct and even a backport request. Finalize the struct definition to avoid a breaking change for those users in the future. RBD_GROUP_SNAP_NAMESPACE_TYPE_USER can be treated as dummy in terms of meaning until RBD_GROUP_SNAP_NAMESPACE_TYPE_MIRROR is added. Signed-off-by: Ilya Dryomov <idryomov@gmail.com>
... and |
0420015 to
45cdd37
Compare
|
jenkins test windows |
|
Looks good to me. It is sufficient to make progress on ceph/go-ceph#1025 once this is merged. Thanks! |
|
jenkins test make check |
|
jenkins test windows |
|
This error is there for other checks as well, but only the Windows check appears to be treating |
|
jenkins test windows |
This is being addressed in ceph/ceph-build#2282. |
Commit e5ccce1 ("rbd: add group snap info command") added a commented out field in rbd_group_snap_info2_t struct but didn't define the corresponding enum, expecting it to be brought in with the patchset that introduces mirror group snapshots. That work is still in progress, but there is already interest in the new command and APIs that use rbd_group_snap_info2_t struct and even a backport request.
Finalize the struct definition to avoid a breaking change for those users in the future. RBD_GROUP_SNAP_NAMESPACE_TYPE_USER can be treated as dummy in terms of meaning until RBD_GROUP_SNAP_NAMESPACE_TYPE_MIRROR is added.
Contribution Guidelines
To sign and title your commits, please refer to Submitting Patches to Ceph.
If you are submitting a fix for a stable branch (e.g. "quincy"), please refer to Submitting Patches to Ceph - Backports for the proper workflow.
When filling out the below checklist, you may click boxes directly in the GitHub web UI. When entering or editing the entire PR message in the GitHub web UI editor, you may also select a checklist item by adding an
xbetween the brackets:[x]. Spaces and capitalization matter when checking off items this way.Checklist
Show available Jenkins commands
jenkins retest this pleasejenkins test classic perfjenkins test crimson perfjenkins test signedjenkins test make checkjenkins test make check arm64jenkins test submodulesjenkins test dashboardjenkins test dashboard cephadmjenkins test apijenkins test docsjenkins render docsjenkins test ceph-volume alljenkins test ceph-volume toxjenkins test windowsjenkins test rook e2e