Skip to content

test/erasure-code: Add ISA configs to the LRC unit tests#59881

Closed
jamiepryde wants to merge 1 commit intoceph:mainfrom
jamiepryde:add-isa-to-lrc-unit-tests
Closed

test/erasure-code: Add ISA configs to the LRC unit tests#59881
jamiepryde wants to merge 1 commit intoceph:mainfrom
jamiepryde:add-isa-to-lrc-unit-tests

Conversation

@jamiepryde
Copy link
Contributor

@jamiepryde jamiepryde commented Sep 19, 2024

The LRC unit tests currently only test the default erasure code plugin (which is currently Jerasure). This PR updates the LRC unit tests to explicitly test profiles with Jerasure and ISA.

Contribution Guidelines

  • To sign and title your commits, please refer to Submitting Patches to Ceph.

  • If you are submitting a fix for a stable branch (e.g. "quincy"), please refer to Submitting Patches to Ceph - Backports for the proper workflow.

  • When filling out the below checklist, you may click boxes directly in the GitHub web UI. When entering or editing the entire PR message in the GitHub web UI editor, you may also select a checklist item by adding an x between the brackets: [x]. Spaces and capitalization matter when checking off items this way.

Checklist

  • Tracker (select at least one)
    • References tracker ticket
    • Very recent bug; references commit where it was introduced
    • New feature (ticket optional)
    • Doc update (no ticket needed)
    • Code cleanup (no ticket needed)
  • Component impact
    • Affects Dashboard, opened tracker ticket
    • Affects Orchestrator, opened tracker ticket
    • No impact that needs to be tracked
  • Documentation (select at least one)
    • Updates relevant documentation
    • No doc update is appropriate
  • Tests (select at least one)
Show available Jenkins commands
  • jenkins retest this please
  • jenkins test classic perf
  • jenkins test crimson perf
  • jenkins test signed
  • jenkins test make check
  • jenkins test make check arm64
  • jenkins test submodules
  • jenkins test dashboard
  • jenkins test dashboard cephadm
  • jenkins test api
  • jenkins test docs
  • jenkins render docs
  • jenkins test ceph-volume all
  • jenkins test ceph-volume tox
  • jenkins test windows
  • jenkins test rook e2e

@jamiepryde
test/erasure-code: Add ISA configs to the LRC unit tests
b9ab44b 
Signed-off-by: Jamie Pryde <jamiepry@uk.ibm.com>
@jamiepryde jamiepryde self-assigned this Sep 19, 2024
@github-actions github-actions bot added the tests label Sep 19, 2024
@markhpc markhpc requested a review from a team September 19, 2024 14:42
markhpc
markhpc approved these changes Sep 26, 2024
View reviewed changes
Copy link
Member

@markhpc markhpc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@markhpc
Copy link
Member

markhpc commented Sep 26, 2024

retest this please

@jamiepryde
Copy link
Contributor Author

jamiepryde commented Oct 10, 2024

jenkins retest this please

@jamiepryde
Copy link
Contributor Author

jamiepryde commented Oct 11, 2024

Make check failure on unittest_erasure_code_lrc is expected until #59862 is merged

@jamiepryde jamiepryde mentioned this pull request Oct 14, 2024
Merged
14 tasks
@jamiepryde
Copy link
Contributor Author

jamiepryde commented Dec 10, 2024

jenkins test make check

@jamiepryde
Copy link
Contributor Author

jamiepryde commented Dec 10, 2024

jenkins test make check arm64

@github-actions
Copy link

github-actions bot commented Feb 8, 2025

This pull request has been automatically marked as stale because it has not had any activity for 60 days. It will be closed if no further activity occurs for another 30 days.
If you are a maintainer or core committer, please follow-up on this pull request to identify what steps should be taken by the author to move this proposed change forward.
If you are the author of this pull request, thank you for your proposed contribution. If you believe this change is still appropriate, please ensure that any feedback has been addressed and ask for a code review.

@github-actions github-actions bot added the stale label Feb 8, 2025
@github-actions
Copy link

github-actions bot commented Mar 10, 2025

This pull request has been automatically closed because there has been no activity for 90 days. Please feel free to reopen this pull request (or open a new one) if the proposed change is still appropriate. Thank you for your contribution!

@github-actions github-actions bot closed this Mar 10, 2025
@jamiepryde jamiepryde reopened this Mar 20, 2025
@github-actions github-actions bot removed the stale label Mar 20, 2025
@jamiepryde
Copy link
Contributor Author

jamiepryde commented Mar 20, 2025

Should hold off on this until #61804 is in.

@github-actions
Copy link

github-actions bot commented May 19, 2025

This pull request has been automatically marked as stale because it has not had any activity for 60 days. It will be closed if no further activity occurs for another 30 days.
If you are a maintainer or core committer, please follow-up on this pull request to identify what steps should be taken by the author to move this proposed change forward.
If you are the author of this pull request, thank you for your proposed contribution. If you believe this change is still appropriate, please ensure that any feedback has been addressed and ask for a code review.

@github-actions github-actions bot added the stale label May 19, 2025
@github-actions
Copy link

github-actions bot commented Jun 18, 2025

This pull request has been automatically closed because there has been no activity for 90 days. Please feel free to reopen this pull request (or open a new one) if the proposed change is still appropriate. Thank you for your contribution!

@github-actions github-actions bot closed this Jun 18, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@markhpc markhpc markhpc approved these changes

Assignees

@jamiepryde jamiepryde

Labels

performance stale tests

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@jamiepryde @markhpc