Skip to content

squid: qa: multiple fixes in test_mirroring.py#59829

Merged
joscollin merged 3 commits intoceph:squidfrom
joscollin:wip-68108-squid
Jul 9, 2025
Merged

squid: qa: multiple fixes in test_mirroring.py#59829
joscollin merged 3 commits intoceph:squidfrom
joscollin:wip-68108-squid

Conversation

@joscollin
Copy link
Member

@joscollin joscollin commented Sep 17, 2024 •
edited
Loading

Fixes test_cephfs_mirror_stats failure and do the set/get attribute on the remote filesystem

Fixes: https://tracker.ceph.com/issues/68108
Fixes: https://tracker.ceph.com/issues/71488
Fixes: https://tracker.ceph.com/issues/70281
Fixes: https://tracker.ceph.com/issues/70514

@joscollin joscollin added this to the squid milestone Sep 17, 2024
@github-actions github-actions bot added the cephfs Ceph File System label Sep 17, 2024
@joscollin
Copy link
Member Author

joscollin commented Sep 18, 2024

jenkins test make check

@github-actions
Copy link

github-actions bot commented Nov 26, 2024

This pull request has been automatically marked as stale because it has not had any activity for 60 days. It will be closed if no further activity occurs for another 30 days.
If you are a maintainer or core committer, please follow-up on this pull request to identify what steps should be taken by the author to move this proposed change forward.
If you are the author of this pull request, thank you for your proposed contribution. If you believe this change is still appropriate, please ensure that any feedback has been addressed and ask for a code review.

@github-actions github-actions bot added the stale label Nov 26, 2024
@joscollin
Copy link
Member Author

joscollin commented Nov 27, 2024

ping

@joscollin joscollin removed the stale label Nov 27, 2024
@mchangir
Copy link
Contributor

mchangir commented Feb 10, 2025

This PR is under test in https://tracker.ceph.com/issues/69882.

joscollin added 3 commits June 24, 2025 19:21
@joscollin
qa: do the set/get attribute on the remote filesystem
268eb9f 
Fixes: https://tracker.ceph.com/issues/67435
Signed-off-by: Jos Collin <jcollin@redhat.com>
(cherry picked from commit 9a46c52)
@joscollin
qa: fix test_cephfs_mirror_stats failure
6efcbea 
100MB files would take less than a second to sync, which makes no difference
in 'last_synced_end' and the test fails intermittently. We need to increase the
size of the files, as the time/duration is determined only in seconds.
Because of this, it also needs more sleep time before checking the status.

Fixes: https://tracker.ceph.com/issues/69232
Signed-off-by: Jos Collin <jcollin@redhat.com>
(cherry picked from commit 005e492)
@joscollin
qa: fix test_cephfs_mirror_stats failure
ca32f0d 
* Don't create huge files that results in 'No space left on device'.
* Relax last_synced_end > last_synced_start check, so that
  the test wouldn't fail even if 'counter dump' delays getting updated
  values within a particular snapshot sync.

Fixes: https://tracker.ceph.com/issues/71186
Signed-off-by: Jos Collin <jcollin@redhat.com>
(cherry picked from commit 9738b8d)
@joscollin joscollin mentioned this pull request Jun 24, 2025
Closed
14 tasks
@joscollin joscollin changed the title squid: qa: do the set/get attribute on the remote filesystem squid: qa: multiple fixes Jun 24, 2025
@joscollin joscollin changed the title squid: qa: multiple fixes squid: qa: multiple fixes in test_mirroring.py Jun 24, 2025
@joscollin
Copy link
Member Author

joscollin commented Jul 8, 2025

This PR is tested in https://tracker.ceph.com/issues/71826.

@hkadam134
The related tests test_cephfs_mirror_stats and test_get_set_mirror_dirty_snap_id are passed in:

So this PR is good to merge.

@hkadam134
Copy link
Contributor

hkadam134 commented Jul 8, 2025

QA Runs Analysed and approved by Jos
-- https://tracker.ceph.com/issues/71826
-- wiki updated - https://tracker.ceph.com/projects/cephfs/wiki/Squid#wip-hemanth2-testing-2025-06-24-1459-squid

The PR is ready to be merged. Need Reviewers' approval

@joscollin joscollin requested a review from a team July 8, 2025 05:51
@joscollin
Copy link
Member Author

joscollin commented Jul 9, 2025

jenkins test make check

@joscollin
Copy link
Member Author

joscollin commented Jul 9, 2025

@vshankar Please approve.

@joscollin joscollin merged commit 399c99e into ceph:squid Jul 9, 2025
13 checks passed
@joscollin joscollin deleted the wip-68108-squid branch July 9, 2025 09:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@vshankar vshankar vshankar approved these changes

Assignees

No one assigned

Labels

cephfs Ceph File System tests

Projects

None yet

Milestone

squid

Development

Successfully merging this pull request may close these issues.

4 participants

@joscollin @mchangir @hkadam134 @vshankar