ceph-volume: add call to ceph-bluestore-tool zap-device#59742
Merged
ceph-volume: add call to ceph-bluestore-tool zap-device#59742
ceph-bluestore-tool zap-device#59742Conversation
599a79b to
a82c7dd
Compare
Contributor
Author
|
jenkins test api |
Contributor
Author
|
needs #59762 |
41a8a4b to
d3d0028
Compare
BlueStore now writes its metadata at multiple offset on devices [1]. It means `ceph-volume lvm zap` doesn't remove BlueStore signature altogether. This can confuse ceph-volume when redeploying an OSD on a previously zapped device because there is still old BlueStore metadata on it. ceph-volume should call `ceph-bluestore-tool zap-device` [2] in addition to the existing calls when wiping a device. [1] ceph#55374 [2] ceph#59632 Fixes: https://tracker.ceph.com/issues/68035 Signed-off-by: Guillaume Abrioux <gabrioux@ibm.com>
d3d0028 to
dcf7439
Compare
Contributor
Author
|
jenkins test make check |
Contributor
Author
|
jenkins test windows |
1 similar comment
Contributor
Author
|
jenkins test windows |
adk3798
approved these changes
Sep 24, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
BlueStore now writes its metadata at multiple offset on devices [1]. It means
ceph-volume lvm zapdoesn't remove BlueStore signature altogether. This can confuse ceph-volume when redeploying an OSD on a previously zapped device because there is still old BlueStore metadata on it.ceph-volume should call
ceph-bluestore-tool zap-device[2] in addition to the existing calls when wiping a device.[1] #55374
[2] #59632
Fixes: https://tracker.ceph.com/issues/68035