squid: mon: fix fs set down to adjust max_mds only when cluster is not down#59704
Merged
mchangir merged 2 commits intoceph:squidfrom Jan 2, 2025
Merged
squid: mon: fix fs set down to adjust max_mds only when cluster is not down#59704mchangir merged 2 commits intoceph:squidfrom
fs set down to adjust max_mds only when cluster is not down#59704mchangir merged 2 commits intoceph:squidfrom
Conversation
Applying `fs set down false` on an up cluster will set the cluster's max_mds to 1, regardless of the cluster's current max_mds. `fs set down false` should only change max_mds when the cluster was set to down. Otherwise, the cluster should remain unchanged. Fixes: https://tracker.ceph.com/issues/66960 Signed-off-by: chungfengz <chungfengz@synology.com> (cherry picked from commit 6bfce64) Conflicts: src/mon/FSCommands.cc Minor conflict in src/mon/FSCommands.cc related to modify_filesystem() helper.
Fixes: https://tracker.ceph.com/issues/66960 Signed-off-by: chungfengz <chungfengz@synology.com> (cherry picked from commit f8becaa)
Contributor
Author
|
jenkins retest this please |
Contributor
Author
|
jenkins test make check |
Contributor
Author
|
jenkins test make check |
1 similar comment
Contributor
Author
|
jenkins test make check |
Contributor
Author
|
This PR is under test in https://tracker.ceph.com/issues/69030. |
mchangir
approved these changes
Jan 2, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
backport tracker: https://tracker.ceph.com/issues/67374
backport of #58582
parent tracker: https://tracker.ceph.com/issues/66960
this backport was staged using ceph-backport.sh version 16.0.0.6848
find the latest version at https://github.com/ceph/ceph/blob/main/src/script/ceph-backport.sh