Skip to content

blk/kerneldevice: notify_all only required when discard_drain wait for condition#59529

Merged
SrinivasaBharath merged 1 commit intoceph:mainfrom
YiteGu:fix-discard-thread-wakeup-each-other
Feb 10, 2025
Merged

blk/kerneldevice: notify_all only required when discard_drain wait for condition#59529
SrinivasaBharath merged 1 commit intoceph:mainfrom
YiteGu:fix-discard-thread-wakeup-each-other

Conversation

@YiteGu
Copy link
Member

@YiteGu YiteGu commented Aug 30, 2024

This will cause discard threads to wake up each other if bdev_async_discard_threads >= 2.

Fixes: https://tracker.ceph.com/issues/67835

Contribution Guidelines

  • To sign and title your commits, please refer to Submitting Patches to Ceph.

  • If you are submitting a fix for a stable branch (e.g. "quincy"), please refer to Submitting Patches to Ceph - Backports for the proper workflow.

  • When filling out the below checklist, you may click boxes directly in the GitHub web UI. When entering or editing the entire PR message in the GitHub web UI editor, you may also select a checklist item by adding an x between the brackets: [x]. Spaces and capitalization matter when checking off items this way.

Checklist

  • Tracker (select at least one)
    • References tracker ticket
    • Very recent bug; references commit where it was introduced
    • New feature (ticket optional)
    • Doc update (no ticket needed)
    • Code cleanup (no ticket needed)
  • Component impact
    • Affects Dashboard, opened tracker ticket
    • Affects Orchestrator, opened tracker ticket
    • No impact that needs to be tracked
  • Documentation (select at least one)
    • Updates relevant documentation
    • No doc update is appropriate
  • Tests (select at least one)
Show available Jenkins commands
  • jenkins retest this please
  • jenkins test classic perf
  • jenkins test crimson perf
  • jenkins test signed
  • jenkins test make check
  • jenkins test make check arm64
  • jenkins test submodules
  • jenkins test dashboard
  • jenkins test dashboard cephadm
  • jenkins test api
  • jenkins test docs
  • jenkins render docs
  • jenkins test ceph-volume all
  • jenkins test ceph-volume tox
  • jenkins test windows
  • jenkins test rook e2e

@YiteGu YiteGu requested a review from a team as a code owner August 30, 2024 11:43
@github-actions github-actions bot added the core label Aug 30, 2024
@YiteGu YiteGu requested a review from ifed01 August 30, 2024 11:43
@YiteGu YiteGu force-pushed the fix-discard-thread-wakeup-each-other branch from a99889e to dfe6a43 Compare October 8, 2024 11:06
@YiteGu
Copy link
Member Author

YiteGu commented Oct 9, 2024

jenkins test make check

@YiteGu
Copy link
Member Author

YiteGu commented Oct 9, 2024

jenkins test api

2 similar comments
@YiteGu
Copy link
Member Author

YiteGu commented Oct 12, 2024

jenkins test api

@YiteGu
Copy link
Member Author

YiteGu commented Oct 15, 2024

jenkins test api

@YiteGu YiteGu force-pushed the fix-discard-thread-wakeup-each-other branch from dfe6a43 to 53f826d Compare October 17, 2024 13:14
@YiteGu YiteGu changed the title blk/kerneldevice: remove notify_all while discard_queued empty blk/kerneldevice: notify_all only required when discard_drain wait for condition Oct 17, 2024
@YiteGu YiteGu force-pushed the fix-discard-thread-wakeup-each-other branch from 53f826d to eff3ab6 Compare October 19, 2024 05:41
@github-actions
Copy link

This pull request can no longer be automatically merged: a rebase is needed and changes have to be manually resolved

…r condition

This will cause discard threads to wake up each other
if bdev_async_discard_threads >= 2.

Fixes: https://tracker.ceph.com/issues/67835

Signed-off-by: Yite Gu <yitegu0@gmail.com>
@YiteGu YiteGu force-pushed the fix-discard-thread-wakeup-each-other branch from eff3ab6 to cec2e45 Compare October 19, 2024 05:45
@YiteGu YiteGu requested a review from ifed01 October 19, 2024 09:50
@ifed01
Copy link
Contributor

ifed01 commented Oct 21, 2024

jenkins test windows

@github-actions
Copy link

This pull request has been automatically marked as stale because it has not had any activity for 60 days. It will be closed if no further activity occurs for another 30 days.
If you are a maintainer or core committer, please follow-up on this pull request to identify what steps should be taken by the author to move this proposed change forward.
If you are the author of this pull request, thank you for your proposed contribution. If you believe this change is still appropriate, please ensure that any feedback has been addressed and ask for a code review.

@github-actions github-actions bot added the stale label Dec 22, 2024
@Matt1360
Copy link
Member

@SrinivasaBharath how did this test? The bot marked this as stale.

@github-actions github-actions bot removed the stale label Dec 22, 2024
@YiteGu YiteGu added this to the v18.2.5 milestone Jan 21, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants