Skip to content

reef: mds: cephx path restriction incorrectly rejects snapshots of deleted directory#59519

Merged
vshankar merged 3 commits intoceph:reeffrom
batrick:wip-67750-reef
Nov 26, 2024
Merged

reef: mds: cephx path restriction incorrectly rejects snapshots of deleted directory#59519
vshankar merged 3 commits intoceph:reeffrom
batrick:wip-67750-reef

Conversation

@batrick
Copy link
Member

@batrick batrick commented Aug 29, 2024

backport tracker: https://tracker.ceph.com/issues/67750


backport of #58419
parent tracker: https://tracker.ceph.com/issues/66828

this backport was staged using ceph-backport.sh version 16.0.0.6848
find the latest version at https://github.com/ceph/ceph/blob/main/src/script/ceph-backport.sh

Signed-off-by: Patrick Donnelly <pdonnell@redhat.com>
(cherry picked from commit 9397f46)
Signed-off-by: Patrick Donnelly <pdonnell@redhat.com>
(cherry picked from commit 6138176)
A snapped unlinked directory is moved to the stray directory. Files in that
directory will not have correct stray_prior_path set because the snapshot was
naturally taken before the file is unlinked.

Use the parent directory's stray_prior_path for cephx path access controls.

Fixes: https://tracker.ceph.com/issues/66828
Signed-off-by: Patrick Donnelly <pdonnell@redhat.com>
(cherry picked from commit 5ad0df3)
@batrick batrick added this to the reef milestone Aug 29, 2024
@batrick batrick added the cephfs Ceph File System label Aug 29, 2024
@github-actions github-actions bot added the tests label Aug 29, 2024
@batrick
Copy link
Member Author

batrick commented Aug 30, 2024

jenkins test api

1 similar comment
@batrick
Copy link
Member Author

batrick commented Aug 30, 2024

jenkins test api

@rishabh-d-dave
Copy link
Contributor

This PR is under test in https://tracker.ceph.com/issues/67949.

Copy link
Contributor

@vshankar vshankar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@vshankar vshankar merged commit 4d820f2 into ceph:reef Nov 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants