squid: mds: cephx path restriction incorrectly rejects snapshots of deleted directory#59518
Merged
mchangir merged 3 commits intoceph:squidfrom Jan 2, 2025
Merged
squid: mds: cephx path restriction incorrectly rejects snapshots of deleted directory#59518mchangir merged 3 commits intoceph:squidfrom
mchangir merged 3 commits intoceph:squidfrom
Conversation
Signed-off-by: Patrick Donnelly <pdonnell@redhat.com> (cherry picked from commit 9397f46)
Signed-off-by: Patrick Donnelly <pdonnell@redhat.com> (cherry picked from commit 6138176)
A snapped unlinked directory is moved to the stray directory. Files in that directory will not have correct stray_prior_path set because the snapshot was naturally taken before the file is unlinked. Use the parent directory's stray_prior_path for cephx path access controls. Fixes: https://tracker.ceph.com/issues/66828 Signed-off-by: Patrick Donnelly <pdonnell@redhat.com> (cherry picked from commit 5ad0df3)
Member
Author
|
jenkins test make check |
4 similar comments
Member
Author
|
jenkins test make check |
Member
Author
|
jenkins test make check |
Member
Author
|
jenkins test make check |
Contributor
|
jenkins test make check |
Contributor
|
This PR is under test in https://tracker.ceph.com/issues/69030. |
mchangir
approved these changes
Jan 2, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
backport tracker: https://tracker.ceph.com/issues/67751
backport of #58419
parent tracker: https://tracker.ceph.com/issues/66828
this backport was staged using ceph-backport.sh version 16.0.0.6848
find the latest version at https://github.com/ceph/ceph/blob/main/src/script/ceph-backport.sh