test/erasure-code: increase ceph_erasure_code_benchmark default buffe…#59486
Merged
SrinivasaBharath merged 1 commit intomainfrom Nov 4, 2024
Merged
Conversation
…r size Signed-off-by: Jamie Pryde <jamiepry@uk.ibm.com>
Contributor
Author
|
Here are some flamegraphs showing CPU utilisation for the bench script run with suggested value: ISA vandermonde encode - ~15% gf encode functions, ~55% aligning buffers, ~20% freeing buffers Jerasure vandermonde encode Bench results |
Contributor
Author
Contributor
Author
|
jenkins test api |
Contributor
Author
|
jenkins test make check |
1 similar comment
Contributor
Author
|
jenkins test make check |
Contributor
Author
|
jenkins test make check |
Contributor
Author
|
jenkins test make check |
2 similar comments
Contributor
Author
|
jenkins test make check |
Contributor
Author
|
jenkins test make check |
14 tasks
14 tasks
Contributor
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.






…r size
The ceph_erasure_code_benchmark tool and bench.sh scripts use small default buffer sizes, and also contain comments that suggest running the tool with a buffer size that is too small. It can be observed from flame graphs captured while using the tool that a majority of CPU time is spent allocating, freeing and aligning buffers, rather than testing the performance of the erasure code plugin.
This PR updates the default settings and comments to suggest a far larger buffer size and far fewer number of encode/decode iterations. Flame graphs show that the vast majority of CPU time is now spent encoding and decoding, rather than aligning buffers.
Contribution Guidelines
To sign and title your commits, please refer to Submitting Patches to Ceph.
If you are submitting a fix for a stable branch (e.g. "quincy"), please refer to Submitting Patches to Ceph - Backports for the proper workflow.
When filling out the below checklist, you may click boxes directly in the GitHub web UI. When entering or editing the entire PR message in the GitHub web UI editor, you may also select a checklist item by adding an
xbetween the brackets:[x]. Spaces and capitalization matter when checking off items this way.Checklist
Show available Jenkins commands
jenkins retest this pleasejenkins test classic perfjenkins test crimson perfjenkins test signedjenkins test make checkjenkins test make check arm64jenkins test submodulesjenkins test dashboardjenkins test dashboard cephadmjenkins test apijenkins test docsjenkins render docsjenkins test ceph-volume alljenkins test ceph-volume toxjenkins test windowsjenkins test rook e2e