Skip to content

reef: qa/cephfs: fix TestRenameCommand and unmount the clinet before failin…#59399

Merged
vshankar merged 1 commit intoceph:reeffrom
lxbsz:wip-67434
Nov 26, 2024
Merged

reef: qa/cephfs: fix TestRenameCommand and unmount the clinet before failin…#59399
vshankar merged 1 commit intoceph:reeffrom
lxbsz:wip-67434

Conversation

@lxbsz
Copy link
Member

@lxbsz lxbsz commented Aug 22, 2024

Backport tracker: https://tracker.ceph.com/issues/67434

Contribution Guidelines

  • To sign and title your commits, please refer to Submitting Patches to Ceph.

  • If you are submitting a fix for a stable branch (e.g. "quincy"), please refer to Submitting Patches to Ceph - Backports for the proper workflow.

  • When filling out the below checklist, you may click boxes directly in the GitHub web UI. When entering or editing the entire PR message in the GitHub web UI editor, you may also select a checklist item by adding an x between the brackets: [x]. Spaces and capitalization matter when checking off items this way.

Checklist

  • Tracker (select at least one)
    • References tracker ticket
    • Very recent bug; references commit where it was introduced
    • New feature (ticket optional)
    • Doc update (no ticket needed)
    • Code cleanup (no ticket needed)
  • Component impact
    • Affects Dashboard, opened tracker ticket
    • Affects Orchestrator, opened tracker ticket
    • No impact that needs to be tracked
  • Documentation (select at least one)
    • Updates relevant documentation
    • No doc update is appropriate
  • Tests (select at least one)
Show available Jenkins commands
  • jenkins retest this please
  • jenkins test classic perf
  • jenkins test crimson perf
  • jenkins test signed
  • jenkins test make check
  • jenkins test make check arm64
  • jenkins test submodules
  • jenkins test dashboard
  • jenkins test dashboard cephadm
  • jenkins test api
  • jenkins test docs
  • jenkins render docs
  • jenkins test ceph-volume all
  • jenkins test ceph-volume tox
  • jenkins test windows
  • jenkins test rook e2e

…g fs

We should else bring and wait for MDS to be up since it is needed
for unmounting of CephFS in CephFSTestCase.tearDown() to be successful,
or just unmount the mountpoints before failing the filesystem.

Since the mountpoint won't be used in later tests so we just unmount
it.

Fixes: https://tracker.ceph.com/issues/66946
Signed-off-by: Xiubo Li <xiubli@redhat.com>
(cherry picked from commit ae3faac)
Conflicts:
  - Just fixed the code needed in reef.
@lxbsz lxbsz requested a review from a team August 22, 2024 08:00
@github-actions github-actions bot added cephfs Ceph File System tests labels Aug 22, 2024
@github-actions github-actions bot added this to the reef milestone Aug 22, 2024
@rishabh-d-dave
Copy link
Contributor

This PR is under test in https://tracker.ceph.com/issues/67949.

Copy link
Contributor

@vshankar vshankar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@vshankar vshankar merged commit 76ffe53 into ceph:reef Nov 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants