Skip to content

reef: qa/cephfs: use different config options to generate MDS_TRIM#59375

Merged
hkadam134 merged 1 commit intoceph:reeffrom
rishabh-d-dave:mds-fs-fail-reef
Feb 13, 2025
Merged

reef: qa/cephfs: use different config options to generate MDS_TRIM#59375
hkadam134 merged 1 commit intoceph:reeffrom
rishabh-d-dave:mds-fs-fail-reef

Conversation

@rishabh-d-dave
Copy link
Contributor

Test test_with_health_warn_trim in classes TestFSFail and TestMDSFail
use config options mds_log_trim_decay_rate and mds_log_trim_threshold
to generte health warning MDS_TRIM which is required for this test.

Since these config options are not present in Reef, use config options
mds_log_max_segments and mds_log_warn_factor to generate health
MDS_TRIM.

Fixes: https://tracker.ceph.com/issues/66829

Contribution Guidelines

  • To sign and title your commits, please refer to Submitting Patches to Ceph.

  • If you are submitting a fix for a stable branch (e.g. "quincy"), please refer to Submitting Patches to Ceph - Backports for the proper workflow.

  • When filling out the below checklist, you may click boxes directly in the GitHub web UI. When entering or editing the entire PR message in the GitHub web UI editor, you may also select a checklist item by adding an x between the brackets: [x]. Spaces and capitalization matter when checking off items this way.

Checklist

  • Tracker (select at least one)
    • References tracker ticket
    • Very recent bug; references commit where it was introduced
    • New feature (ticket optional)
    • Doc update (no ticket needed)
    • Code cleanup (no ticket needed)
  • Component impact
    • Affects Dashboard, opened tracker ticket
    • Affects Orchestrator, opened tracker ticket
    • No impact that needs to be tracked
  • Documentation (select at least one)
    • Updates relevant documentation
    • No doc update is appropriate
  • Tests (select at least one)
Show available Jenkins commands
  • jenkins retest this please
  • jenkins test classic perf
  • jenkins test crimson perf
  • jenkins test signed
  • jenkins test make check
  • jenkins test make check arm64
  • jenkins test submodules
  • jenkins test dashboard
  • jenkins test dashboard cephadm
  • jenkins test api
  • jenkins test docs
  • jenkins render docs
  • jenkins test ceph-volume all
  • jenkins test ceph-volume tox
  • jenkins test windows
  • jenkins test rook e2e

@rishabh-d-dave rishabh-d-dave requested a review from a team August 21, 2024 07:37
@github-actions github-actions bot added this to the reef milestone Aug 21, 2024
Test test_with_health_warn_trim in classes TestFSFail and TestMDSFail
use config options mds_log_trim_decay_rate and mds_log_trim_threshold
to generte health warning MDS_TRIM which is required for this test.

Since these config options are not present in Reef, use config options
mds_log_max_segments and mds_log_warn_factor to generate health
MDS_TRIM.

Fixes: https://tracker.ceph.com/issues/66829
Signed-off-by: Rishabh Dave <ridave@redhat.com>
@batrick
Copy link
Member

batrick commented Aug 29, 2024

@rishabh-d-dave please work with the Wrangler to get this into the next batch.

@rishabh-d-dave
Copy link
Contributor Author

@hkadam134 @vshankar Any update about the QA run for this PR?

@hkadam134
Copy link
Contributor

@rishabh-d-dave - Here is the QA Runs Tracker - https://tracker.ceph.com/issues/68852 and job details are updated in the tracker.

@hkadam134
Copy link
Contributor

QA Tracker : https://tracker.ceph.com/issues/69534

@rishabh-d-dave rishabh-d-dave changed the title qa/cephfs: use different config options to generate MDS_TRIM reef: qa/cephfs: use different config options to generate MDS_TRIM Jan 28, 2025
@mchangir
Copy link
Contributor

This PR is under test in https://tracker.ceph.com/issues/69881.

@hkadam134
Copy link
Contributor

hkadam134 commented Feb 11, 2025

@rishabh-d-dave – Two new issues were found during testing:
https://tracker.ceph.com/issues/69898
https://tracker.ceph.com/issues/69899

Could you review and confirm whether these are unrelated to the fix? Based on your confirmation, I'll proceed with merging the PR.

The rest of the test runs look good. - https://pad.ceph.com/p/hyelloji-2025-01-15_07_12_26-fs-wip-hemanth1
Wiki - https://tracker.ceph.com/projects/cephfs/wiki/Reef#wip-hemanth1-testing-2025-01-13-1558-reef

@vshankar
Copy link
Contributor

@rishabh-d-dave – Two new issues were found during testing: https://tracker.ceph.com/issues/69898 https://tracker.ceph.com/issues/69899

Could you review and confirm whether these are unrelated to the fix? Based on your confirmation, I'll proceed with merging the PR.

The rest of the test runs look good. - https://pad.ceph.com/p/hyelloji-2025-01-15_07_12_26-fs-wip-hemanth1 Wiki - https://tracker.ceph.com/projects/cephfs/wiki/Reef#wip-hemanth1-testing-2025-01-13-1558-reef

I have request @mchangir to have a look at the run wiki and the results.

@mchangir
Copy link
Contributor

mchangir commented Feb 12, 2025

@rishabh-d-dave – Two new issues were found during testing: https://tracker.ceph.com/issues/69898 https://tracker.ceph.com/issues/69899
Could you review and confirm whether these are unrelated to the fix? Based on your confirmation, I'll proceed with merging the PR.
The rest of the test runs look good. - https://pad.ceph.com/p/hyelloji-2025-01-15_07_12_26-fs-wip-hemanth1 Wiki - https://tracker.ceph.com/projects/cephfs/wiki/Reef#wip-hemanth1-testing-2025-01-13-1558-reef

I have request @mchangir to have a look at the run wiki and the results.

@rishabh-d-dave test failures referenced by the trackers do not seem to have any correlation with the PRs being tested

@hkadam134
Copy link
Contributor

Milind confirmed that the failures documented in the Wiki are unrelated to the PRs selected for this QA run. SO, we are good to merge.
https://tracker.ceph.com/issues/69534#note-15

@hkadam134 hkadam134 merged commit dfde102 into ceph:reef Feb 13, 2025
1 check passed
@mchangir
Copy link
Contributor

This PR is under test in https://tracker.ceph.com/issues/70178.

@rishabh-d-dave rishabh-d-dave deleted the mds-fs-fail-reef branch March 6, 2025 11:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants