reef: mgr/rest: Trim requests array and limit size#59371
Merged
Conversation
Presently, the requests array in the REST module has the potential to grow indefinitely, leading to excessive memory consumption, particularly when dealing with lengthy and intricate request results. To address this issue, a limit will be imposed on the requests array within the REST module. This limitation will be governed by the `mgr/restful/x/max_requests` configuration parameter specific to the REST module. when submit_request called we will check request array if exceed max_request option if it does we will check if the future trimmed request finished and log error message in case we are trimming un-finished requests. Fixes: https://tracker.ceph.com/issues/59580 Signed-off-by: Nitzan Mordechai <nmordech@redhat.com> (cherry picked from commit 58281c1)
rzarzynski
requested changes
Nov 7, 2024
PendingReleaseNotes
Outdated
| the notifications, new configs will be used. | ||
| * RBD: The option ``--image-id`` has been added to `rbd children` CLI command, | ||
| so it can be run for images in the trash. | ||
| * PG dump: The default output of `ceph pg dump --format json` has changed. The |
Contributor
There was a problem hiding this comment.
Hmm, haven't these items snaked into the PR?
15c8f96 to
38c06c7
Compare
rzarzynski
approved these changes
Nov 27, 2024
anthonyeleven
approved these changes
Nov 27, 2024
Contributor
Author
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
backport tracker: https://tracker.ceph.com/issues/67644
backport of #54984
parent tracker: https://tracker.ceph.com/issues/67642
this backport was staged using ceph-backport.sh version 16.0.0.6848
find the latest version at https://github.com/ceph/ceph/blob/main/src/script/ceph-backport.sh