Skip to content

reef: mgr/rest: Trim requests array and limit size#59371

Merged
yuriw merged 3 commits intoceph:reeffrom
NitzanMordhai:wip-67644-reef
Jan 10, 2025
Merged

reef: mgr/rest: Trim requests array and limit size#59371
yuriw merged 3 commits intoceph:reeffrom
NitzanMordhai:wip-67644-reef

Conversation

@NitzanMordhai
Copy link
Contributor

backport tracker: https://tracker.ceph.com/issues/67644


backport of #54984
parent tracker: https://tracker.ceph.com/issues/67642

this backport was staged using ceph-backport.sh version 16.0.0.6848
find the latest version at https://github.com/ceph/ceph/blob/main/src/script/ceph-backport.sh

Presently, the requests array in the REST module has the potential to grow
indefinitely, leading to excessive memory consumption, particularly when
dealing with lengthy and intricate request results.

To address this issue, a limit will be imposed on the requests array within
the REST module.
This limitation will be governed by the `mgr/restful/x/max_requests` configuration
parameter specific to the REST module.
when submit_request called we will check request array if exceed max_request option
if it does we will check if the future trimmed request finished and log error
message in case we are trimming un-finished requests.

Fixes: https://tracker.ceph.com/issues/59580
Signed-off-by: Nitzan Mordechai <nmordech@redhat.com>
(cherry picked from commit 58281c1)
the notifications, new configs will be used.
* RBD: The option ``--image-id`` has been added to `rbd children` CLI command,
so it can be run for images in the trash.
* PG dump: The default output of `ceph pg dump --format json` has changed. The
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hmm, haven't these items snaked into the PR?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yes, fixing

…max_request option

Signed-off-by: Nitzan Mordechai <nmordech@redhat.com>
(cherry picked from commit 7b251ca)
Signed-off-by: Nitzan Mordechai <nmordech@redhat.com>
(cherry picked from commit dd7e8bb)
@NitzanMordhai
Copy link
Contributor Author

@yuriw yuriw merged commit 6e5e0d2 into ceph:reef Jan 10, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants