qa: load all dirfrags before testing altname recovery#59310
qa: load all dirfrags before testing altname recovery#59310
Conversation
|
jenkins test api |
| self.fs.set_joinable() | ||
| self.fs.wait_for_daemons() | ||
|
|
||
| self.mount_a.run_shell_payload(f"cd {self.path} && find") |
There was a problem hiding this comment.
IMO, it'll be helpful to place a comment here explaining why we need this before calling verify_alternate_name(). Perhaps something like # Add dirfrag to memory/cache since rank will not have it because journal was reset. The commit message is pretty good, so something like it.
I am not sure if it's worth it but, should we consider moving this line to inside verify_alternate_name()? Placing this line next to first line in there (J = self.fs.read_cache("/dir", depth=0) makes the context of this line clearer.
There was a problem hiding this comment.
I've added a comment. I don't think the belongs in verify_alternate_name which is just doing introspective commands on the MDS.
The journal reset effectively cleared the cache so the rank may not have the dirfrag in memory when we verify alternate name recovery. Fixes: https://tracker.ceph.com/issues/67511 Signed-off-by: Patrick Donnelly <pdonnell@redhat.com>
|
jenkins test make check arm64 |
|
This PR is under test in https://tracker.ceph.com/issues/67711. |
|
Adding this to a future run. Don't wait for me to merge. |
|
This PR is under test in https://tracker.ceph.com/issues/67757. |
The journal reset effectively cleared the cache so the rank may not have the dirfrag in memory when we verify alternate name recovery.
Fixes: https://tracker.ceph.com/issues/67511
Contribution Guidelines
To sign and title your commits, please refer to Submitting Patches to Ceph.
If you are submitting a fix for a stable branch (e.g. "quincy"), please refer to Submitting Patches to Ceph - Backports for the proper workflow.
When filling out the below checklist, you may click boxes directly in the GitHub web UI. When entering or editing the entire PR message in the GitHub web UI editor, you may also select a checklist item by adding an
xbetween the brackets:[x]. Spaces and capitalization matter when checking off items this way.Checklist
Show available Jenkins commands
jenkins retest this pleasejenkins test classic perfjenkins test crimson perfjenkins test signedjenkins test make checkjenkins test make check arm64jenkins test submodulesjenkins test dashboardjenkins test dashboard cephadmjenkins test apijenkins test docsjenkins render docsjenkins test ceph-volume alljenkins test ceph-volume toxjenkins test windowsjenkins test rook e2e