Skip to content

qa/suites: Make fixed-4 an option for verify tests#59155

Merged
SrinivasaBharath merged 1 commit intoceph:mainfrom
badone:wip-tracker-67489-fixed-4-for-verify
Jan 17, 2025
Merged

qa/suites: Make fixed-4 an option for verify tests#59155
SrinivasaBharath merged 1 commit intoceph:mainfrom
badone:wip-tracker-67489-fixed-4-for-verify

Conversation

@badone
Copy link
Contributor

@badone badone commented Aug 12, 2024 •
edited
Loading

Fixes: https://tracker.ceph.com/issues/67489

Contribution Guidelines

  • To sign and title your commits, please refer to Submitting Patches to Ceph.

  • If you are submitting a fix for a stable branch (e.g. "quincy"), please refer to Submitting Patches to Ceph - Backports for the proper workflow.

  • When filling out the below checklist, you may click boxes directly in the GitHub web UI. When entering or editing the entire PR message in the GitHub web UI editor, you may also select a checklist item by adding an x between the brackets: [x]. Spaces and capitalization matter when checking off items this way.

Checklist

  • Tracker (select at least one)
    • References tracker ticket
    • Very recent bug; references commit where it was introduced
    • New feature (ticket optional)
    • Doc update (no ticket needed)
    • Code cleanup (no ticket needed)
  • Component impact
    • Affects Dashboard, opened tracker ticket
    • Affects Orchestrator, opened tracker ticket
    • No impact that needs to be tracked
  • Documentation (select at least one)
    • Updates relevant documentation
    • No doc update is appropriate
  • Tests (select at least one)
Show available Jenkins commands
  • jenkins retest this please
  • jenkins test classic perf
  • jenkins test crimson perf
  • jenkins test signed
  • jenkins test make check
  • jenkins test make check arm64
  • jenkins test submodules
  • jenkins test dashboard
  • jenkins test dashboard cephadm
  • jenkins test api
  • jenkins test docs
  • jenkins render docs
  • jenkins test ceph-volume all
  • jenkins test ceph-volume tox
  • jenkins test windows
  • jenkins test rook e2e

@badone
qa/suites: Make fixed-4 an option for verify tests
a3d0c62 
Fixes: https://tracker.ceph.com/issues/67489
Signed-off-by: Brad Hubbard <bhubbard@redhat.com>
@badone badone requested a review from a team as a code owner August 12, 2024 03:16
@badone badone requested a review from batrick August 12, 2024 04:24
@badone
Copy link
Contributor Author

badone commented Aug 12, 2024

@batrick sanity check please?

@badone badone requested review from ljflores and yuriw September 3, 2024 00:53
@badone
Copy link
Contributor Author

badone commented Sep 3, 2024

This is a trivial, but necessary change to get these tests running again.

batrick
batrick approved these changes Oct 9, 2024
View reviewed changes
Copy link
Member

@batrick batrick left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is in response to our discussion in #59029 (comment)

?

LGTM

@batrick
Copy link
Member

batrick commented Oct 9, 2024

jenkins test api

@batrick
Copy link
Member

batrick commented Oct 9, 2024

jenkins test make check arm64

@badone
Copy link
Contributor Author

badone commented Oct 31, 2024

Can we at least get a review from the QA team as a run may, or may not, be required (at your discretion).

@ljflores
Copy link
Member

ljflores commented Jan 16, 2025

Hey @badone, sorry for the delay on this review. There is a related issue:
/a/yuriw-2024-11-18_15:14:17-rados-wip-yuri3-testing-2024-11-14-0857-distro-default-smithi/7998146

2024-11-18T18:22:53.704 INFO:teuthology.task.kernel:config {'mon.a': {'branch': 'distro', 'kdb': 1, 'sha1': 'distro'}, 'mon.b': {'branch': 'distro', 'kdb': 1, 'sha1': 'distro'}, 'osd.10': {'branch': 'distro', 'kdb': 1, 'sha1': 'distro'}, 'osd.11': {'branch': 'distro', 'kdb': 1, 'sha1': 'distro'}}, timeout 300
2024-11-18T18:22:53.704 DEBUG:teuthology.orchestra.run.smithi173:> test -f /run/.containerenv -o -f /.dockerenv
2024-11-18T18:22:53.705 DEBUG:teuthology.orchestra.run.smithi176:> test -f /run/.containerenv -o -f /.dockerenv
2024-11-18T18:22:53.705 ERROR:teuthology.run_tasks:Saw exception from tasks.
Traceback (most recent call last):
  File "/home/teuthworker/src/git.ceph.com_teuthology_d61fe8ceee8390fd00680e26d6042e17e98866e6/teuthology/run_tasks.py", line 112, in run_tasks
    manager.__enter__()
  File "/usr/lib/python3.10/contextlib.py", line 135, in __enter__
    return next(self.gen)
  File "/home/teuthworker/src/git.ceph.com_teuthology_d61fe8ceee8390fd00680e26d6042e17e98866e6/teuthology/task/kernel.py", line 1236, in task
    with parallel() as p:
  File "/home/teuthworker/src/git.ceph.com_teuthology_d61fe8ceee8390fd00680e26d6042e17e98866e6/teuthology/parallel.py", line 84, in __exit__
    for result in self:
  File "/home/teuthworker/src/git.ceph.com_teuthology_d61fe8ceee8390fd00680e26d6042e17e98866e6/teuthology/parallel.py", line 98, in __next__
    resurrect_traceback(result)
  File "/home/teuthworker/src/git.ceph.com_teuthology_d61fe8ceee8390fd00680e26d6042e17e98866e6/teuthology/parallel.py", line 30, in resurrect_traceback
    raise exc.exc_info[1]
  File "/home/teuthworker/src/git.ceph.com_teuthology_d61fe8ceee8390fd00680e26d6042e17e98866e6/teuthology/parallel.py", line 23, in capture_traceback
    return func(*args, **kwargs)
  File "/home/teuthworker/src/git.ceph.com_teuthology_d61fe8ceee8390fd00680e26d6042e17e98866e6/teuthology/task/kernel.py", line 1251, in process_role
    (role_remote,) = ctx.cluster.only(role).remotes.keys()
ValueError: too many values to unpack (expected 1)

@SrinivasaBharath SrinivasaBharath merged commit 32b2c7b into ceph:main Jan 17, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@batrick batrick batrick approved these changes

@yuriw yuriw yuriw approved these changes

@ljflores ljflores Awaiting requested review from ljflores

Assignees

No one assigned

Labels

core TESTED tests

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@badone @batrick @ljflores @yuriw @SrinivasaBharath