squid: msg: insert PriorityDispatchers in sorted position#58991
Merged
SrinivasaBharath merged 1 commit intoceph:squidfrom Oct 16, 2024
Merged
squid: msg: insert PriorityDispatchers in sorted position#58991SrinivasaBharath merged 1 commit intoceph:squidfrom
SrinivasaBharath merged 1 commit intoceph:squidfrom
Conversation
avoid calling stable_sort() after every insertion by inserting directly into the sorted position. use lower_bound() to insert at the head and upper_bound() to insert at the tail this generally only happens during startup so isn't a performance problem, but std::stable_sort() was triggering strange valgrind warnings for "Mismatched free() / delete / delete []" when it allocates a temporary buffer Fixes: https://tracker.ceph.com/issues/66336 Signed-off-by: Casey Bodley <cbodley@redhat.com> (cherry picked from commit 063d100)
vshankar
approved these changes
Aug 1, 2024
dang
approved these changes
Sep 4, 2024
rzarzynski
approved these changes
Sep 5, 2024
Contributor
|
This PR is under test in https://tracker.ceph.com/issues/67948. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
backport tracker: https://tracker.ceph.com/issues/67307
backport of #58631
parent tracker: https://tracker.ceph.com/issues/66336
this backport was staged using ceph-backport.sh version 16.0.0.6848
find the latest version at https://github.com/ceph/ceph/blob/main/src/script/ceph-backport.sh