Skip to content

squid: client: Fix leading / issue with mds_check_access#58981

Closed
kotreshhr wants to merge 3 commits intoceph:squidfrom
kotreshhr:wip-67293-squid
Closed

squid: client: Fix leading / issue with mds_check_access#58981
kotreshhr wants to merge 3 commits intoceph:squidfrom
kotreshhr:wip-67293-squid

Conversation

@kotreshhr
Copy link
Contributor

@kotreshhr kotreshhr commented Aug 1, 2024

backport tracker: https://tracker.ceph.com/issues/67293


backport of #58878
parent tracker: https://tracker.ceph.com/issues/67212

Also backported a required qa fix 7626bd5

this backport was staged using ceph-backport.sh version 16.0.0.6848
find the latest version at https://github.com/ceph/ceph/blob/main/src/script/ceph-backport.sh

@kotreshhr kotreshhr added this to the squid milestone Aug 1, 2024
@kotreshhr kotreshhr added the cephfs Ceph File System label Aug 1, 2024
@github-actions github-actions bot added the tests label Aug 1, 2024
@kotreshhr kotreshhr requested a review from a team August 1, 2024 07:27
@lxbsz
Copy link
Member

lxbsz commented Aug 2, 2024

jenkins test make check

@lxbsz
Copy link
Member

lxbsz commented Aug 2, 2024

jenkins test api

@lxbsz
Copy link
Member

lxbsz commented Aug 6, 2024

jenkins test make check

Copy link
Contributor

@vshankar vshankar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@kotreshhr PTAL at the failure.

rishabh-d-dave and others added 3 commits September 11, 2024 13:15
Signed-off-by: Rishabh Dave <ridave@redhat.com>
(cherry picked from commit 7626bd5)
Fixes: https://tracker.ceph.com/issues/67212
Signed-off-by: Kotresh HR <khiremat@redhat.com>
(cherry picked from commit 983f893)
The "Client::mds_check_access" expects the target_path without
leading '/' as it eventually calls the "MDSCapMatch::match_path"
which expects the target_path passed to be with out leading '/'
as well.

The single leading '/' was being removed. But absolute path
constructed did have leading '//', so removing all the leading
'/' was necessary.

This causes the clients not to be able to access a particular
path even though it has a rw permission on the specific path.

The patche fixes the leading '//' issue.

Fixes: https://tracker.ceph.com/issues/67212
Signed-off-by: Kotresh HR <khiremat@redhat.com>
(cherry picked from commit 2e2adb2)
@kotreshhr
Copy link
Contributor Author

jenkins test api

@vshankar vshankar added the wip-vshankar-testing2-squid Squid Backport Testing #2 label Nov 6, 2024
@vshankar
Copy link
Contributor

vshankar commented Nov 6, 2024

This PR is under test in https://tracker.ceph.com/issues/68851.

@github-actions
Copy link

github-actions bot commented Jan 5, 2025

This pull request has been automatically marked as stale because it has not had any activity for 60 days. It will be closed if no further activity occurs for another 30 days.
If you are a maintainer or core committer, please follow-up on this pull request to identify what steps should be taken by the author to move this proposed change forward.
If you are the author of this pull request, thank you for your proposed contribution. If you believe this change is still appropriate, please ensure that any feedback has been addressed and ask for a code review.

@github-actions github-actions bot added the stale label Jan 5, 2025
@github-actions
Copy link

github-actions bot commented Feb 4, 2025

This pull request has been automatically closed because there has been no activity for 90 days. Please feel free to reopen this pull request (or open a new one) if the proposed change is still appropriate. Thank you for your contribution!

@github-actions github-actions bot closed this Feb 4, 2025
@kotreshhr kotreshhr reopened this Jun 17, 2025
@kotreshhr kotreshhr removed the stale label Jun 17, 2025
@kotreshhr
Copy link
Contributor Author

jenkins test make check

@kotreshhr
Copy link
Contributor Author

The PR #65359 takes care of this backport

@kotreshhr kotreshhr closed this Sep 8, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

cephfs Ceph File System tests wip-vshankar-testing2-squid Squid Backport Testing #2

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants