Skip to content

ceph-fuse: Improve fuse mount usage message#58847

Merged
vshankar merged 1 commit intoceph:mainfrom
kotreshhr:improve-fusecmd-usage
Nov 5, 2024
Merged

ceph-fuse: Improve fuse mount usage message#58847
vshankar merged 1 commit intoceph:mainfrom
kotreshhr:improve-fusecmd-usage

Conversation

@kotreshhr
Copy link
Contributor

@kotreshhr kotreshhr commented Jul 25, 2024

Show '--client_fs ' option in fuse usage
which is required to mount a specific fs in multifs cluster.

https://tracker.ceph.com/issues/67283
Signed-off-by: Kotresh HR khiremat@redhat.com

Contribution Guidelines

  • To sign and title your commits, please refer to Submitting Patches to Ceph.

  • If you are submitting a fix for a stable branch (e.g. "quincy"), please refer to Submitting Patches to Ceph - Backports for the proper workflow.

  • When filling out the below checklist, you may click boxes directly in the GitHub web UI. When entering or editing the entire PR message in the GitHub web UI editor, you may also select a checklist item by adding an x between the brackets: [x]. Spaces and capitalization matter when checking off items this way.

Checklist

  • Tracker (select at least one)
    • References tracker ticket
    • Very recent bug; references commit where it was introduced
    • New feature (ticket optional)
    • Doc update (no ticket needed)
    • Code cleanup (no ticket needed)
  • Component impact
    • Affects Dashboard, opened tracker ticket
    • Affects Orchestrator, opened tracker ticket
    • No impact that needs to be tracked
  • Documentation (select at least one)
    • Updates relevant documentation
    • No doc update is appropriate
  • Tests (select at least one)
Show available Jenkins commands
  • jenkins retest this please
  • jenkins test classic perf
  • jenkins test crimson perf
  • jenkins test signed
  • jenkins test make check
  • jenkins test make check arm64
  • jenkins test submodules
  • jenkins test dashboard
  • jenkins test dashboard cephadm
  • jenkins test api
  • jenkins test docs
  • jenkins render docs
  • jenkins test ceph-volume all
  • jenkins test ceph-volume tox
  • jenkins test windows
  • jenkins test rook e2e

@kotreshhr kotreshhr requested a review from a team July 25, 2024 10:33
@github-actions github-actions bot added the cephfs Ceph File System label Jul 25, 2024
@batrick
Copy link
Member

batrick commented Jul 25, 2024

Let's open a tracker for backport.

@kotreshhr kotreshhr force-pushed the improve-fusecmd-usage branch from 2b7b325 to 8d89d5f Compare July 31, 2024 07:25
@kotreshhr
Copy link
Contributor Author

Let's open a tracker for backport.

Done

@kotreshhr
Copy link
Contributor Author

jenkins test api

@kotreshhr
Copy link
Contributor Author

jenkins test make check

@kotreshhr
Copy link
Contributor Author

jenkins test windows

@kotreshhr
Copy link
Contributor Author

jenkins test make check

@kotreshhr kotreshhr requested a review from a team July 31, 2024 12:40
@kotreshhr
Copy link
Contributor Author

jenkins test make check arm64

@kotreshhr kotreshhr force-pushed the improve-fusecmd-usage branch from c17fe47 to cdaad55 Compare August 13, 2024 12:51
@kotreshhr
Copy link
Contributor Author

@batrick PTAL

Copy link
Member

@batrick batrick left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

the component in the commit title would be better as "ceph-fuse" rather than "fuse".

@kotreshhr kotreshhr changed the title fuse: Improve fuse mount usage message ceph-fuse: Improve fuse mount usage message Oct 15, 2024
Show '--client_fs <fsname>' option in 'ceph-fuse' usage
which is required to mount a specific fs in multifs cluster.

https://tracker.ceph.com/issues/67283
Signed-off-by: Kotresh HR <khiremat@redhat.com>
@kotreshhr kotreshhr force-pushed the improve-fusecmd-usage branch from cdaad55 to 7cd6024 Compare October 15, 2024 04:32
@kotreshhr
Copy link
Contributor Author

the component in the commit title would be better as "ceph-fuse" rather than "fuse".

Done

@kotreshhr
Copy link
Contributor Author

@batrick assigned it you since you already reviewed this and had a minor nit. :)

@batrick
Copy link
Member

batrick commented Oct 31, 2024

This PR is under test in https://tracker.ceph.com/issues/68786.

@vshankar vshankar merged commit 4e355ce into ceph:main Nov 5, 2024
@vshankar
Copy link
Contributor

vshankar commented Nov 5, 2024

This PR is under test in https://tracker.ceph.com/issues/68786.

@batrick I merged this as it is a straight-forward string change.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants