quincy: mds/client: return -ENODATA when xattr doesn't exist for removexattr#58772
quincy: mds/client: return -ENODATA when xattr doesn't exist for removexattr#58772lxbsz wants to merge 3 commits intoceph:quincyfrom
Conversation
The POSIX says we should return -ENODATA when the corresponding attribute doesn't exist when removing it. While there is one exception for the acl ones in the local filesystems, for exmaple for xfs, which will treat it as success. While in the MDS side there have two ways to remove the xattr: sending a CEPH_MDS_OP_SETXATTR request by setting the 'flags' with CEPH_XATTR_REMOVE and just issued a CEPH_MDS_OP_RMXATTR request directly. For the first one it will always return 0 when the corresponding xattr doesn't exist, while for the later one it will return -ENODATA instead, this should be fixed in MDS to make them to be consistent. Added a CEPH_XATTR_REMOVE2 new flags and will return -ENODATA errno directly when the crresponding xattr doesn't exist. Just keeps the old CEPH_XATTR_REMOVE flags to make it to be compatible with old clients. Fixes: https://tracker.ceph.com/issues/64679 Signed-off-by: Xiubo Li <xiubli@redhat.com> (cherry picked from commit 797e926)
There have two ways to remove xattrs, removexattr() and setxattr() with the XATTR_REPLACE flags set. Fixes: https://tracker.ceph.com/issues/64679 Signed-off-by: Xiubo Li <xiubli@redhat.com> (cherry picked from commit 1a27670) Conflicts: src/test/libcephfs/vxattr.cc Missing commit fa125c4("test/libcephfs: move FsCrypt xattr test to dedicated test file"), which makes no sense in this backporting.
Fixes: https://tracker.ceph.com/issues/64679 Signed-off-by: Xiubo Li <xiubli@redhat.com> (cherry picked from commit b2a07f8) Conflicts: qa/workunits/libcephfs/test.sh src/test/libcephfs/CMakeLists.txt Missing commit 540f396("test/libcephfs: move the snapdiff to a dedicated binary")
|
jenkins test make check |
1 similar comment
|
jenkins test make check |
|
This pull request has been automatically marked as stale because it has not had any activity for 60 days. It will be closed if no further activity occurs for another 30 days. |
|
This pull request has been automatically closed because there has been no activity for 90 days. Please feel free to reopen this pull request (or open a new one) if the proposed change is still appropriate. Thank you for your contribution! |
backport tracker: https://tracker.ceph.com/issues/66776
backport of #55945
parent tracker: https://tracker.ceph.com/issues/64679
This backport will just ignore the following comit:
Which makes no sense in quincy.
Contribution Guidelines
To sign and title your commits, please refer to Submitting Patches to Ceph.
If you are submitting a fix for a stable branch (e.g. "quincy"), please refer to Submitting Patches to Ceph - Backports for the proper workflow.
When filling out the below checklist, you may click boxes directly in the GitHub web UI. When entering or editing the entire PR message in the GitHub web UI editor, you may also select a checklist item by adding an
xbetween the brackets:[x]. Spaces and capitalization matter when checking off items this way.Checklist
Show available Jenkins commands
jenkins retest this pleasejenkins test classic perfjenkins test crimson perfjenkins test signedjenkins test make checkjenkins test make check arm64jenkins test submodulesjenkins test dashboardjenkins test dashboard cephadmjenkins test apijenkins test docsjenkins render docsjenkins test ceph-volume alljenkins test ceph-volume toxjenkins test windowsjenkins test rook e2e