reef: mds: fix session/client evict command.#58726
Merged
Conversation
added 3 commits
July 22, 2024 21:11
This commit fixes the issues in client/session evict command using below solutions: (1) client evict without filter is forbidden (2) SessionFilter::parse is modified to support id=* (id=0 is not allowed) (3) Invalid id error is handled User can use client evict id=* to evict all clients. Fixes: https://tracker.ceph.com/issues/58619 Signed-off-by: Neeraj Pratap Singh <neesingh@redhat.com> (cherry picked from commit 0ef5941)
Since the tests in the class test_misc.TestSessionClientEvict requires 3 clients, this should be run with a yaml that configures 3 clients. Hence, removing the link to 1-mds-2-client.yaml from qa/suits/fs/multiclient/clusters/ Fixes: https://tracker.ceph.com/issues/58619 Signed-off-by: Neeraj Pratap Singh <neesingh@redhat.com> (cherry picked from commit 5d8fd4c)
Adds a test class test_misc.TestSessionClientEvict which contains test for the issues mentioned in this PR. Fixes: https://tracker.ceph.com/issues/58619 Signed-off-by: Neeraj Pratap Singh <neesingh@redhat.com> (cherry picked from commit f3e674d)
Member
|
jenkins test make check |
1 similar comment
Member
|
jenkins test make check |
Contributor
|
This PR is under test in https://tracker.ceph.com/issues/67981. |
Introduced-by: 0ef5941 Fixes: http://tracker.ceph.com/issues/68132 Signed-off-by: Venky Shankar <vshankar@redhat.com> (cherry picked from commit 4277cd2)
vshankar
approved these changes
Nov 9, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
backport tracker: https://tracker.ceph.com/issues/67077
backport of #49974
parent tracker: https://tracker.ceph.com/issues/58619
this backport was staged using ceph-backport.sh version 16.0.0.6848
find the latest version at https://github.com/ceph/ceph/blob/main/src/script/ceph-backport.sh