quincy: mds: fix session/client evict command.#58724
Conversation
This commit fixes the issues in client/session evict command using below solutions: (1) client evict without filter is forbidden (2) SessionFilter::parse is modified to support id=* (id=0 is not allowed) (3) Invalid id error is handled User can use client evict id=* to evict all clients. Fixes: https://tracker.ceph.com/issues/58619 Signed-off-by: Neeraj Pratap Singh <neesingh@redhat.com> (cherry picked from commit 0ef5941)
Since the tests in the class test_misc.TestSessionClientEvict requires 3 clients, this should be run with a yaml that configures 3 clients. Hence, removing the link to 1-mds-2-client.yaml from qa/suits/fs/multiclient/clusters/ Fixes: https://tracker.ceph.com/issues/58619 Signed-off-by: Neeraj Pratap Singh <neesingh@redhat.com> (cherry picked from commit 5d8fd4c)
Adds a test class test_misc.TestSessionClientEvict which contains test for the issues mentioned in this PR. Fixes: https://tracker.ceph.com/issues/58619 Signed-off-by: Neeraj Pratap Singh <neesingh@redhat.com> (cherry picked from commit f3e674d)
|
jenkins test make check |
1 similar comment
|
jenkins test make check |
Introduced-by: 0ef5941 Fixes: http://tracker.ceph.com/issues/68132 Signed-off-by: Venky Shankar <vshankar@redhat.com> (cherry picked from commit 4277cd2)
|
The recent commit d38eb5d is causing failures in quincy: https://pulpito.ceph.com/yuriw-2024-10-17_13:52:02-fs-wip-yuri12-testing-2024-10-16-1152-quincy-distro-default-smithi/7953797/ I had pushed the commit I mention since its fixed a regression introduced by the change, however, the test runs were done without the commit I mention and therefore the failure wasn't seen in the test run. The underlying reason for the failures is failing to handle a non-json return value for |
|
The same test in main branch passed: https://pulpito.ceph.com/teuthology-2024-10-01_20:24:05-fs-main-distro-default-smithi/7927718/ Its probably missing backports in the qa source that handles empty (non-json) return values for mds tell command. |
Tracker for fixing this: https://tracker.ceph.com/issues/68639 |
backport tracker: https://tracker.ceph.com/issues/67076
backport of #49974
parent tracker: https://tracker.ceph.com/issues/58619
this backport was staged using ceph-backport.sh version 16.0.0.6848
find the latest version at https://github.com/ceph/ceph/blob/main/src/script/ceph-backport.sh