Skip to content

common/Formatter: dump inf/nan as null#58598

Merged
SrinivasaBharath merged 1 commit intoceph:mainfrom
sajibreadd:wip-66215
Sep 27, 2024
Merged

common/Formatter: dump inf/nan as null#58598
SrinivasaBharath merged 1 commit intoceph:mainfrom
sajibreadd:wip-66215

Conversation

@sajibreadd
Copy link
Member

@sajibreadd sajibreadd commented Jul 15, 2024

Fixes: https://tracker.ceph.com/issues/66215
Reference PR: #57695

Contribution Guidelines

  • To sign and title your commits, please refer to Submitting Patches to Ceph.

  • If you are submitting a fix for a stable branch (e.g. "quincy"), please refer to Submitting Patches to Ceph - Backports for the proper workflow.

  • When filling out the below checklist, you may click boxes directly in the GitHub web UI. When entering or editing the entire PR message in the GitHub web UI editor, you may also select a checklist item by adding an x between the brackets: [x]. Spaces and capitalization matter when checking off items this way.

Checklist

  • Tracker (select at least one)
    • References tracker ticket
    • Very recent bug; references commit where it was introduced
    • New feature (ticket optional)
    • Doc update (no ticket needed)
    • Code cleanup (no ticket needed)
  • Component impact
    • Affects Dashboard, opened tracker ticket
    • Affects Orchestrator, opened tracker ticket
    • No impact that needs to be tracked
  • Documentation (select at least one)
    • Updates relevant documentation
    • No doc update is appropriate
  • Tests (select at least one)
Show available Jenkins commands
  • jenkins retest this please
  • jenkins test classic perf
  • jenkins test crimson perf
  • jenkins test signed
  • jenkins test make check
  • jenkins test make check arm64
  • jenkins test submodules
  • jenkins test dashboard
  • jenkins test dashboard cephadm
  • jenkins test api
  • jenkins test docs
  • jenkins render docs
  • jenkins test ceph-volume all
  • jenkins test ceph-volume tox
  • jenkins test windows
  • jenkins test rook e2e

@sajibreadd sajibreadd force-pushed the wip-66215 branch 2 times, most recently from d7d7477 to 081f949 Compare July 15, 2024 14:43
@batrick batrick requested a review from ifed01 July 15, 2024 14:54
@sajibreadd
Copy link
Member Author

sajibreadd commented Jul 16, 2024

jenkins test make check

@sajibreadd
Copy link
Member Author

sajibreadd commented Jul 16, 2024

jenkins test api

@sajibreadd
Copy link
Member Author

sajibreadd commented Jul 16, 2024

jenkins test windows

2 similar comments
@sajibreadd
Copy link
Member Author

sajibreadd commented Jul 16, 2024

jenkins test windows

@sajibreadd
Copy link
Member Author

sajibreadd commented Jul 17, 2024

jenkins test windows

@sajibreadd
Copy link
Member Author

sajibreadd commented Jul 17, 2024

jenkins test make check

@sajibreadd
Copy link
Member Author

sajibreadd commented Jul 17, 2024

jenkins test api

@sajibreadd
Copy link
Member Author

sajibreadd commented Jul 17, 2024

jenkins test windows

@sajibreadd
Copy link
Member Author

sajibreadd commented Jul 18, 2024

jenkins test make check

@sajibreadd
Copy link
Member Author

sajibreadd commented Jul 18, 2024

jenkins test windows

@petrutlucian94
Copy link
Contributor

petrutlucian94 commented Jul 18, 2024

Seems like a legit failure, I think it has something to do with the precision: https://jenkins.ceph.com/job/ceph-windows-pull-requests/43810/artifact/artifacts/test_results/out/unittest_json_formatter/unittest_json_formatter_results.log

@sajibreadd
Copy link
Member Author

sajibreadd commented Jul 18, 2024

Not sure why the test is failing in windows.
image
image
Did the exact think in the testing used CachedStackStringStream to convert the double value into string.

But in json it is dumping "inf"(get_data()) and in test(css_max->strv()) it is showing "1.7976931348623157e+308"
https://jenkins.ceph.com/job/ceph-windows-pull-requests/43815/artifact/artifacts/test_results/out/unittest_json_formatter/unittest_json_formatter_results.log

I am out of my observations, @batrick @ifed01 any thoughts on this?

@sajibreadd
Copy link
Member Author

sajibreadd commented Jul 29, 2024

jenkins test windows

@sajibreadd
common/Formatter: dump inf/nan as null
214328d 
Fixes: https://tracker.ceph.com/issues/66215
Signed-off-by: Md Mahamudur Rahaman Sajib <mahamudur.sajib@croit.io>
@sajibreadd
Copy link
Member Author

sajibreadd commented Aug 2, 2024

jenkins test make check

@SrinivasaBharath SrinivasaBharath merged commit a9b3ba1 into ceph:main Sep 27, 2024
This was referenced Sep 30, 2024
Merged
Closed
Merged
@sajibreadd sajibreadd deleted the wip-66215 branch March 16, 2026 08:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@batrick batrick batrick approved these changes

@ifed01 ifed01 ifed01 approved these changes

Assignees

No one assigned

Labels

common needs-qa TESTED tests

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@sajibreadd @petrutlucian94 @batrick @ifed01 @SrinivasaBharath