squid: client: check mds down status before getting mds_gid_t from mdsmap#58587
Merged
vshankar merged 2 commits intoceph:squidfrom Nov 4, 2024
Merged
squid: client: check mds down status before getting mds_gid_t from mdsmap#58587vshankar merged 2 commits intoceph:squidfrom
vshankar merged 2 commits intoceph:squidfrom
Conversation
…fails Fixes: https://tracker.ceph.com/issues/64089 Signed-off-by: Dhairya Parmar <dparmar@redhat.com> (cherry picked from commit 564dba3) (cherry picked from commit e99486e)
Get mds_gid_t from up of MDSMap, will cause to core dump if target
mds_rank_t does not exist up map:
from: src/mds/MDSMap.h
const auto& get_info(mds_rank_t m) const {
return mds_info.at(up.at(m));
}
reproduct:
1. ceph fs fail <fs_name>
2. curl -X GET "example.com:8080/api/cephfs/1/clients" ...
up.at(m) will cause to core dump.
Fixes: https://tracker.ceph.com/issues/61844
Signed-off-by: Yite Gu <yitegu0@gmail.com>
(cherry picked from commit 878463e)
Member
Author
|
backport PR create by |
Member
Author
|
jenkins test make check |
1 similar comment
Member
Author
|
jenkins test make check |
nizamial09
approved these changes
Jul 22, 2024
Contributor
|
This PR is under test in https://tracker.ceph.com/issues/67948. |
Member
Author
thanks @rishabh-d-dave |
vshankar
approved these changes
Nov 4, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
backport tracker: https://tracker.ceph.com/issues/64606
backport of #52258
parent tracker: https://tracker.ceph.com/issues/61844
this backport was staged using ceph-backport.sh version 16.0.0.6848
find the latest version at https://github.com/ceph/ceph/blob/main/src/script/ceph-backport.sh