squid: qa/cephfs: mark file system joinable for fs rename tests before unmounting clients#58495
Merged
lxbsz merged 2 commits intoceph:squidfrom Jul 22, 2024
Merged
squid: qa/cephfs: mark file system joinable for fs rename tests before unmounting clients#58495lxbsz merged 2 commits intoceph:squidfrom
lxbsz merged 2 commits intoceph:squidfrom
Conversation
…nting clients Fixes: http://tracker.ceph.com/issues/66088 Signed-off-by: Venky Shankar <vshankar@redhat.com> (cherry picked from commit 74452ad)
To avoid all sorts for races that could happen when using sleep(). Signed-off-by: Rishabh Dave <ridave@redhat.com> Signed-off-by: Venky Shankar <vshankar@redhat.com> (cherry picked from commit 3005495)
Member
Author
|
jenkins test api |
Member
Author
|
This PR is under test in https://tracker.ceph.com/issues/66906. |
lxbsz
reviewed
Jul 19, 2024
| self.fail("expected renaming of a non-existent file system to fail") | ||
| self.run_ceph_cmd(f'fs set {self.fs.name} joinable true') | ||
| self.fs.wait_for_daemons() | ||
| self.run_ceph_cmd(f'fs set {self.fs.name} refuse_client_session false') |
Member
There was a problem hiding this comment.
I am afraid this change just triggered this test failure:
Maybe we should set refuse_client_session to false just before pulling the fs cluster up ?
lxbsz
approved these changes
Jul 22, 2024
Member
lxbsz
left a comment
There was a problem hiding this comment.
None of the failure is related to this backport PR:
More detail please see section 2024-07-17 in https://tracker.ceph.com/projects/cephfs/wiki/Squid.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes: https://tracker.ceph.com/issues/66728
Contribution Guidelines
To sign and title your commits, please refer to Submitting Patches to Ceph.
If you are submitting a fix for a stable branch (e.g. "quincy"), please refer to Submitting Patches to Ceph - Backports for the proper workflow.
When filling out the below checklist, you may click boxes directly in the GitHub web UI. When entering or editing the entire PR message in the GitHub web UI editor, you may also select a checklist item by adding an
xbetween the brackets:[x]. Spaces and capitalization matter when checking off items this way.Checklist
Show available Jenkins commands
jenkins retest this pleasejenkins test classic perfjenkins test crimson perfjenkins test signedjenkins test make checkjenkins test make check arm64jenkins test submodulesjenkins test dashboardjenkins test dashboard cephadmjenkins test apijenkins test docsjenkins render docsjenkins test ceph-volume alljenkins test ceph-volume toxjenkins test windowsjenkins test rook e2e